Bug 237775

Summary: Wrong init script
Product: Red Hat Enterprise Linux 5 Reporter: Michal Marciniszyn <mmarcini>
Component: arptables_jfAssignee: Jiri Skala <jskala>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: aglotov, mbarabas, riek, tvujec
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-09-09 07:54:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 237776, 237778, 237789    

Description Michal Marciniszyn 2007-04-25 12:13:17 UTC
Description of problem:
In several occasions, the script may end with return code 0 even when the
service does not start correctly. For example
if [ ! -x /sbin/arptables ]; then
        exit 0
fi

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. change access rights such that /sbin/arptables is not executable
2. service arptables_jf start
3. echo $?
  
Actual results:
0

Expected results:
Non-zero exit code with respect to our guidelines.

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

Comment 4 Michal Nowak 2008-07-14 14:06:20 UTC
/CoreOS/arptables_jf/237776-wrong-init-script

Comment 7 RHEL Program Management 2008-09-09 07:54:15 UTC
Quality Engineering Management has reviewed and declined this request.  You may
appeal this decision by reopening this request.