Bug 238073 (perl-GTop)

Summary:	Review Request: perl-GTop - Perl interface to libgtop
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Ville Skyttä <ville.skytta>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	adrian
Target Milestone:	---	Flags:	ville.skytta: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/GTop/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-04-30 21:02:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	238211

Description Chris Weyl 2007-04-26 22:38:07 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-GTop-0.16-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-GTop.spec

Description:
This is a perl interface to the libgtop library, useful for collecting
real-time performance and other system statistics

Comment 1 Chris Weyl 2007-04-26 22:38:55 UTC

This package is a (testing) prereq of the Catalyst framework.

Comment 2 Ville Skyttä 2007-04-27 06:45:06 UTC

Missing '.' at end of %description.

examples/perlbloat.pl doesn't add any problematic dependencies and it's a useful
script, so I think it could be considered better included executable. 

Perhaps fix up the interpreters to %{__perl} instead of hardcoded /usr/bin/perl
for the examples?

Those are mild suggestions only, otherwise looks good, approved no matter if
addressed or not.

Comment 3 Chris Weyl 2007-04-27 17:38:07 UTC

Thanks for the review :)  I just started a "perl vs %{__perl}" thread on
fedora-perl-devel -- from your comment in the other bug it sounds like this
might be a good idea across the board...  Making that script executable and your
other comments are well taken :)  

I'll make the modifications post-import if that's ok...

Comment 4 Chris Weyl 2007-04-27 17:38:33 UTC

New Package CVS Request
=======================
Package Name: perl-GTop
Short Description: Perl interface to libgtop
Owners: cweyl.edu
Branches: FC-5, FC-6, devel
InitialCC: fedora-perl-devel-list

Comment 5 Chris Weyl 2007-04-30 21:02:26 UTC

Imported and building -- thanks for the review! :)

Comment 6 Marcela Mašláňová 2010-12-22 12:15:13 UTC

Package Change Request
======================
Package Name: perl-GTop
New Branches: el6
Owners: mmaslano psabata ppisar cweyl


It is needed for perl-Event-Lib.

Comment 7 Adrian Reber 2010-12-22 16:31:56 UTC

    dbbb

Comment 8 Jason Tibbitts 2010-12-22 17:18:18 UTC

Git done (by process-git-requests).