Bug 2380990

Summary: dnf-plugins-core-4.10.1-8.fc45 FTBFS with CMake using ninja: make: *** No targets specified and no makefile found.
Product: [Fedora] Fedora Reporter: Cristian Le <fedora>
Component: dnf-plugins-coreAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 44CC: daniel.mach, jmracek, mblaha, packaging-team-maint, pkratoch, ppisar, praiskup, rpm-software-management
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dnf-plugins-core-4.10.1-9.fc45 dnf-plugins-core-4.10.1-9.fc44 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-03-14 00:15:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2376112, 2384424, 2433833    

Description Cristian Le 2025-07-16 15:13:10 UTC
Dear package maintainer,

This is an automated bug created due to a FTBFS when rebuilding this package for the change proposal CMake: Use ninja generator by default.

The rebuild is being tracked in https://copr.fedorainfracloud.org/coprs/lecris/cmake-ninja/package/dnf-plugins-core.

See https://fedoraproject.org/wiki/Changes/CMake_ninja_default for more information on how to make the package compatible.

More specifically, make sure you are using standard %cmake_* macros. If you find that there are hard dependencies on
the generator even after such transition, please ping me for closer investigation.

You can check the build locally following the instructions in the change proposal, or submit your build to the tracking
copr project.

Let me know if you encounter any issues, or need any other help.

Comment 1 Petr Pisar 2026-02-25 12:19:17 UTC
This switch to ninja happened in cmake-4.2.3-2.fc45.x86_64.

Comment 2 Petr Pisar 2026-02-25 12:21:17 UTC
F44 is also affected.

Comment 3 Cristian Le 2026-02-25 12:51:05 UTC
See the open PR for it: https://src.fedoraproject.org/rpms/dnf-plugins-core/pull-request/5

Comment 4 Petr Pisar 2026-02-25 13:15:07 UTC
I have a simpler fix <https://github.com/rpm-software-management/dnf-plugins-core/pull/609>.

Comment 5 Cristian Le 2026-02-25 13:42:09 UTC
Either works, the one in that PR also drops `__cmake_in_source_build 1` to truely use the cmake macros as they are more intended to be used

Comment 6 Petr Pisar 2026-02-25 13:44:45 UTC
I saw that, but the _vpath_builddir macro is not documented in the guidelines, so I'd like to avoid it.

Comment 7 Cristian Le 2026-02-25 13:53:06 UTC
> I saw that, but the _vpath_builddir macro is not documented in the guidelines, so I'd like to avoid it.

https://docs.fedoraproject.org/en-US/packaging-guidelines/vpath/

Also see the warning about `%__cmake_builddir` in https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/#_available_macros

Comment 8 Fedora Update System 2026-02-26 16:36:23 UTC
FEDORA-2026-1ed5afe8f2 (dnf-plugins-core-4.10.1-9.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-1ed5afe8f2

Comment 9 Fedora Update System 2026-02-27 01:36:44 UTC
FEDORA-2026-1ed5afe8f2 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-1ed5afe8f2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-1ed5afe8f2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2026-03-14 00:15:42 UTC
FEDORA-2026-1ed5afe8f2 (dnf-plugins-core-4.10.1-9.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.