Bug 2381117

Summary:	rocm-compilersupport: FTBFS with change proposal CMake: Use ninja generator by default
Product:	[Fedora] Fedora	Reporter:	Cristian Le <fedora>
Component:	rocm-compilersupport	Assignee:	Tom.Rix
Status:	CLOSED RAWHIDE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	rocm-packagers-sig, Tom.Rix
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-08-10 05:36:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2376112

Description Cristian Le 2025-07-16 15:22:50 UTC

Dear package maintainer,

This is an automated bug created due to a FTBFS when rebuilding this package for the change proposal CMake: Use ninja generator by default.

The rebuild is being tracked in https://copr.fedorainfracloud.org/coprs/lecris/cmake-ninja/package/rocm-compilersupport.

See https://fedoraproject.org/wiki/Changes/CMake_ninja_default for more information on how to make the package compatible.

More specifically, make sure you are using standard %cmake_* macros. If you find that there are hard dependencies on
the generator even after such transition, please ping me for closer investigation.

You can check the build locally following the instructions in the change proposal, or submit your build to the tracking
copr project.

Let me know if you encounter any issues, or need any other help.

Comment 1 Tom.Rix 2025-07-18 17:39:25 UTC

 !! Copr timeout => sending INT
Copr build error: Build failed

Increase the timeout on your copr and try again.

Comment 2 Cristian Le 2025-07-21 12:59:28 UTC

Did a rebuild, and it fails at questionable sections
```
-- Build files have been written to: /builddir/build/BUILD/rocm-compilersupport-19-build/llvm-project-rocm-6.4.1/build-comgr
+ sed -i -e s.19.0git@ build-comgr/CMakeFiles/amd_comgr.dir/link.txt
sed: can't read build-comgr/CMakeFiles/amd_comgr.dir/link.txt: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.xhl7QV (%build)
```

I am actually lost on what that is supposed to be doing.

Comment 3 Tom.Rix 2025-08-09 14:35:37 UTC

Can you check if this change fixes the issue ?
https://src.fedoraproject.org/rpms/rocm-compilersupport/c/878261eeebbede5f9f220522155fb1ccd8110df8?branch=rawhide

Comment 4 Cristian Le 2025-08-10 05:36:30 UTC

Rebuild submitted: https://copr.fedorainfracloud.org/coprs/lecris/cmake-ninja/build/9394464/

It should work, but the preferred approach is to add
```
%global _cmake_generator "Unix Makefiles"
```
This would avoid having multiple `-G` flags in the `cmake` command. It should be fine because it seems to be taking the last value.