Bug 2381272

Summary:	libwebsockets: FTBFS with change proposal CMake drop non-standard variables
Product:	[Fedora] Fedora	Reporter:	Cristian Le <fedora>
Component:	libwebsockets	Assignee:	Fabian Affolter <mail>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mail, pbrobinson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-11-30 20:08:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2376113

Description Cristian Le 2025-07-16 15:44:39 UTC

Dear package maintainer,

This is an automated bug created due to a FTBFS when rebuilding this package for the change proposal CMake drop non-standard variables.

The rebuild is being tracked in https://copr.fedorainfracloud.org/coprs/lecris/cmake-drop_vars/package/libwebsockets.

See https://fedoraproject.org/wiki/Changes/CMake_drop_install_vars for more information on how to make the package compatible.

Most likely the build failure is due to the project assuming the presence of `LIB_SUFFIX` as an input. You can provide
this variable as shown in the change proposal. If possible, please open an issue in upstream and ask them to use
`GNUInstallDirs` instead.

You can check the build locally following the instructions in the change proposal, or submit your build to the tracking
copr project.

Let me know if you encounter any issues, or need any other help.

Comment 1 Peter Robinson 2025-07-21 21:05:41 UTC

I think this is fixed, but honestly I can't tell from the bug report or the linked change. Please confirm.

Comment 2 Cristian Le 2025-07-22 15:48:37 UTC

If it's about https://koji.fedoraproject.org/koji/buildinfo?buildID=2751505, I have checked the build log, and I don't think the issue is resolved.
```
-- Configuring done (15.4s)
-- Generating done (0.1s)
CMake Warning:
  Manually-specified variables were not used by the project:
    CMAKE_CXX_FLAGS_RELEASE
    CMAKE_C_FLAGS_RELEASE
    CMAKE_Fortran_FLAGS_RELEASE
    CMAKE_INSTALL_DO_STRIP
    CMAKE_INSTALL_FULL_SBINDIR
    CMAKE_INSTALL_SBINDIR
    INCLUDE_INSTALL_DIR
    LIB_INSTALL_DIR
    LWS_USE_BUNDLED_ZLIB
    SHARE_INSTALL_PREFIX
    SYSCONF_INSTALL_DIR
-- Build files have been written to: /builddir/build/BUILD/libwebsockets-4.4.1-build/libwebsockets-4.4.1/redhat-linux-build
```

I don't see `LIB_SUFFIX` there, so it seems to still be using it in one form or another. I have to check with upstream source to confirm where though

Comment 3 Cristian Le 2025-07-22 16:21:58 UTC

I've made an upstream PR for this. Feel free to use either that PR or the workaround in the change-proposal document.

Comment 4 Peter Robinson 2025-11-30 20:08:13 UTC

According to the upstream PR it was merged to both the main branch and 4.4.x branch so with 4.4.2 this should be fixed.