Bug 238232 (perl-Catalyst-Manual)
Summary: | Review Request: perl-Catalyst-Manual - Catalyst web framework manual | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | rmo |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
tcallawa: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Catalyst-Manual/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-06-05 15:53:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 238238 |
Description
Chris Weyl
2007-04-28 03:05:55 UTC
Could you explain this? # this is actually better done in perl-Catalyst-Runtime %exclude %{_mandir}/man3/Catalyst::Manual.3* It doesn't seem right to me to exclude the documentation of the primary perl-module being within a package (Here: perl(Catalyst::Manual)) Yes -- perl-Catalyst-Runtime actually includes a manpage for Catalyst::Manual, one that is (oddly) more useful than the one included in this package. Given that we'd have a conflict, I chose the one that seemed more useful. Looking back over the spec, because of this it'd probably make more sense to also require perl(Catalyst). Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 70f872c92533a39ca6893871ec4d3223 Catalyst-Manual-5.700701.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/pod-coverage....ok t/pod.............ok All tests successful. Files=2, Tests=20, 1 wallclock secs ( 0.78 cusr + 0.03 csys = 0.81 CPU) + exit 0 + Provides: perl(Catalyst::Manual) = 5.700701 + Requires: perl(:MODULE_COMPAT_5.8.8) APPROVED. New Package CVS Request ======================= Package Name: perl-Catalyst-Manual Short Description: Catalyst web framework manual Owners: cweyl.edu Branches: FC-5, FC-6, F-7, devel InitialCC: fedora-perl-devel-list cvs done. Imported and building. Thanks for the review! :) |