Bug 2383208
| Summary: | dash dependency disabled but rpmlint/checks/BashismsCheck.py still included | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Ulrik Haugen <ulrik.haugen> | ||||
| Component: | rpmlint | Assignee: | Ulrik Haugen <fedora> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | epel10 | CC: | fedora, j, mhroncok, spotrh, twoerner | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | rpmlint-2.7.0-6.el10_1 | Doc Type: | --- | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-08-06 01:04:55 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Ulrik Haugen
2025-07-24 11:18:14 UTC
Yes, the check needs to be disabled. Perhaps https://src.fedoraproject.org/rpms/rpmlint/c/1a851a987dbb855fd89988ed0b6d41a05d1ba189?branch=rawhide was not 100 % correct. Will you be able to submit a PR for this? I could take a stab at it next week. I just created https://src.fedoraproject.org/rpms/rpmlint/pull-request/52, it's my first pull request to a Fedora package so i have some questions. I created it against the rawhide branch, should it have been the epel10 branch instead? I assumed you'd want to handle the release tag and changelog. Despite waiting for a long time after adding an ssh key to Fas src.fedoraproject.org never stopped saying "You need to upload SSH key to be able to clone over SSH", in the end i made the changes through the web editor, do you happen to know what i should have done? Also the green "merge" button in my pull request concerns me somewhat, have i somehow gotten permissions to do that? (In reply to Ulrik Haugen from comment #3) > I just created https://src.fedoraproject.org/rpms/rpmlint/pull-request/52, > it's my first pull request to a Fedora package so i have some questions. Congratulations! > I created it against the rawhide branch, should it have been the epel10 > branch instead? Depends on the package in question. Here we have epel10 and rawhide branches more or less in sync, so it doesn't really matter. You can open 2 PR form the smwe branch, so the CI build runs on rawhide + EPEL and we can verify the results. > I assumed you'd want to handle the release tag and changelog. Nah, it's better if you add that to your PR. > Despite waiting for a long time after adding an ssh key to Fas > src.fedoraproject.org never stopped saying "You need to upload SSH key to be > able to clone over SSH", in the end i made the changes through the web > editor, do you happen to know what i should have done? If you are not in the packager group, you cannot push via SSH, you need to push via HTTPS. See https://docs.fedoraproject.org/en-US/ci/pull-requests/#_you_are_not_a_packager (In reply to Ulrik Haugen from comment #4) > Also the green "merge" button in my pull request concerns me somewhat, have > i somehow gotten permissions to do that? I think this is just a Pagure UI fail, the merge button will unroll a set of options, and you will see none. See https://pagure.io/pagure/issue/5251 (In reply to Miro Hrončok from comment #5) > (In reply to Ulrik Haugen from comment #3) > > I created it against the rawhide branch, should it have been the epel10 > > branch instead? > > Depends on the package in question. Here we have epel10 and rawhide branches > more or less in sync, so it doesn't really matter. You can open 2 PR form > the smwe branch, so the CI build runs on rawhide + EPEL and we can verify > the results. Ok, i'll hold off on the second pull request until after lunch to see if i get some more feedback in the first one. > > I assumed you'd want to handle the release tag and changelog. > > Nah, it's better if you add that to your PR. Ok, i added that just now. > > Despite waiting for a long time after adding an ssh key to Fas > > src.fedoraproject.org never stopped saying "You need to upload SSH key to be > > able to clone over SSH", in the end i made the changes through the web > > editor, do you happen to know what i should have done? > > If you are not in the packager group, you cannot push via SSH, you need to > push via HTTPS. See > https://docs.fedoraproject.org/en-US/ci/pull-requests/ > #_you_are_not_a_packager I see, thank you for the pointer! FEDORA-EPEL-2025-cedf160322 (rpmlint-2.7.0-6.el10_1) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-cedf160322 FEDORA-EPEL-2025-cedf160322 has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-cedf160322 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-cedf160322 (rpmlint-2.7.0-6.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report. |