Bug 2383529
| Summary: | Review Request: rust-lasso - A fast, concurrent string interner for Rust | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-07-30 23:01:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2383530 | ||
|
Description
Yaakov Selkowitz
2025-07-25 16:55:32 UTC
The package builds successfully, but two of the non-default feature subpackages don't install due to missing dependencies: Problem 1: conflicting requests - nothing provides (crate(abomonation) >= 0.7.3 with crate(abomonation) < 0.8.0~) needed by rust-lasso+abomonation-devel-0.7.3-1.fc43.noarch from @commandline Problem 2: conflicting requests - nothing provides (crate(deepsize) >= 0.2.0 with crate(deepsize) < 0.3.0~) needed by rust-lasso+deepsize-devel-0.7.3-1.fc43.noarch from @commandline I would suggest to "hide" the "abomonation" and "deepsize" features or patch out these two optional dependencies from Cargo.toml. Spec URL: https://yselkowitz.fedorapeople.org/rust-lasso.spec SRPM URL: https://yselkowitz.fedorapeople.org/rust-lasso-0.7.3-1.fc43.src.rpm Looks good to me now, thanks.
One last thing: I suggest you %exclude the benches/input.txt file from the "rust-lasso-devel" package (i.e. "%exclude %{crate_instdir}/benches/input.txt"), it's from a different project and covered by a different license. And it's unused in the package, so excluding it is an easy workaround.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org:
project: $crate
homepage: https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter (*NOT* pre-release filter): alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)
Oh, and I forgot: I suggest dropping the "A " prefix for the Summary. rust2rpm would strip it if it were there upstream :) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lasso FEDORA-2025-8d8aaba12e (rust-lasso-0.7.3-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-8d8aaba12e FEDORA-2025-8d8aaba12e (rust-lasso-0.7.3-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |