Bug 2383530

Initial review
==============

1. These should both be unused / noops in this kind of package, please remove them:

> %global cargo_install_lib 0
> %global crate grass

2. Use the standard / documented SourceURL format for GitHub sources please:

> Source:         https://github.com/connorskees/grass/archive/refs/tags/%{version}/%{crate}-%{version}.tar.gz
> %autosetup -n %{crate}-%{version} -p1

becomes

> Source:         https://github.com/connorskees/grass/archive/%{version}/grass-%{version}.tar.gz
> %autosetup -n grass-%{version} -p1

3. Don't "cd" into some subdirectory, it shouldn't be necessary:

> %generate_buildrequires
> cd crates/lib
> %cargo_generate_buildrequires

becomes

> %generate_buildrequires
> %cargo_generate_buildrequires

etc. (and analogue changes in the other scriptlets and in the %files list)

Not sure why you thought this was necessary - it should be a noop and just looks confusing.
Running cargo at the top-level (i.e. where the top-level Cargo.toml with the workspace definition is) should work just fine.

Oh, and this one too (4., I guess):

> %bcond check 0

This means "don't pull in test dependencies, don't compile tests, don't run tests".

If this is due to an actual issue that prevents tests from being compiled or run, please document this issue. Otherwise, flip it to "1" please.

Spec URL: https://yselkowitz.fedorapeople.org/grass-compiler.spec
SRPM URL: https://yselkowitz.fedorapeople.org/grass-compiler-0.13.4-1.fc43.src.rpm

It seems %cargo_install isn't usable in this case.

> It seems %cargo_install isn't usable in this case.

Yeah, that's fine. Even if it worked, it would just be a glorified wrapper around `install` in this case - so, equivalent to what you replaced it with.

===

With the latest changes, the package now looks good to me.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the project is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ licenses of statically linked dependencies are correctly taken into account
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

- add @rust-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/grass-compiler

FEDORA-2025-dd211fa464 (grass-compiler-0.13.4-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-dd211fa464

FEDORA-2025-dd211fa464 (grass-compiler-0.13.4-2.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Please don't forget to file bugs for the compilation failures in the tests ...

(In reply to Fabio Valentini from comment #8)
> Please don't forget to file bugs for the compilation failures in the tests ...

https://src.fedoraproject.org/rpms/grass-compiler/pull-request/1