Bug 238597

Summary: update CIFS client to 1.48aRH
Product: Red Hat Enterprise Linux 5 Reporter: Jeff Layton <jlayton>
Component: kernelAssignee: Jeff Layton <jlayton>
Status: CLOSED ERRATA QA Contact: Martin Jenner <mjenner>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: amyagi, carenas, coughlan, ddomingo, dkelson, ssorce, staubach, steved
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2007-0959 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-07 19:48:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 222082    
Attachments:
Description Flags
patch -- update RHEL5 CIFS code to 1.48a
none
patch -- update RHEL5 CIFS code to 1.48aRH
none
patch -- delta from upstream tarball
none
tarball with backport of 1.48 for older kernels none

Description Jeff Layton 2007-05-01 18:28:26 UTC
This is a tracking BZ for tracking the update of the CIFS client code to 1.48a.
Given that that's how CIFS updates have generally been handled in the past, it's
probably best to continue that in RHEL5 as well.

Comment 2 Jeff Layton 2007-05-01 18:35:48 UTC
Created attachment 153882 [details]
patch -- update RHEL5 CIFS code to 1.48a

This patch updates the RHEL5 CIFS code to 1.48a. It should apply cleanly on top

of 2.6.18-17.el5. Cursory testing indicates that it works as expected. Still
working on more in-depth testing...

Comment 3 RHEL Program Management 2007-05-01 18:44:02 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Jeff Layton 2007-05-07 16:44:29 UTC
Created attachment 154279 [details]
patch -- update RHEL5 CIFS code to 1.48aRH

This is essentially identical to the other patch, but I folded in the patch for
bug #227973, and customized the version string.

Comment 5 Jeff Layton 2007-05-07 18:33:19 UTC
Testing done so far:

Connectathon test against FC6 samba (both with and without unix extensions),
win2k and win2k3. All basic and general tests pass. Special tests fall down
about halfway through, but they do that as well on the prior kernel.

fsstress tests run against samba -- no problems

Also, basic "hello" world type testing on all different hosts. Worked fine.


Comment 8 Jeff Layton 2007-05-08 17:29:56 UTC
I also need to clarify, if you mount a samba server with unix extensions
enabled, all the connectathon tests pass. If you disable them or run against a
windows machine, then the special tests fail early on.


Comment 10 Jeff Layton 2007-05-09 13:41:53 UTC
*** Bug 224476 has been marked as a duplicate of this bug. ***

Comment 11 Jeff Layton 2007-05-09 13:42:33 UTC
*** Bug 227973 has been marked as a duplicate of this bug. ***

Comment 12 Jeff Layton 2007-06-07 16:14:17 UTC
Created attachment 156476 [details]
patch -- delta from upstream tarball

This patch is the delta on top of Steve French's backport. It's a few small
changes to make this build correctly on RHEL5, and also contains a patch that
went upstream after 1.48 came out to force an anonymous mount when sec=none is
specified on the command line.

Comment 13 Jeff Layton 2007-06-07 16:16:15 UTC
Created attachment 156478 [details]
tarball with backport of 1.48 for older kernels

This tarball contains the backport of the 1.48 code to earlier kernels that
Steve French did. The patch is based on this tarball.

Comment 14 Steve Dickson 2007-06-08 10:50:11 UTC
Why is the 'RH'added the version?

-#define CIFS_VERSION   "1.47"
+#define CIFS_VERSION   "1.48aRH"



Comment 15 Jeff Layton 2007-06-08 10:54:29 UTC
I noticed that Steve F. had forgotten to bump the version number when he rolled
this tarball so I figured we should fix that up. Also since this code isn't
really the *exact* 1.48a code it would be good to distinguish it somehow.

Comment 16 Steve Dickson 2007-06-08 11:20:30 UTC
Well logically its the same... unless I miss something there are no 
additional bug fixes or features... but I guess its a non-issue
as long as continue to stamp 'RH' for now on... (i.e. keeping
it consistent) 

Comment 18 Don Zickus 2007-06-16 00:31:54 UTC
in 2.6.18-27.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 19 Akemi Yagi 2007-06-30 18:53:28 UTC
(In reply to comment #18)
> in 2.6.18-27.el5
> You can download this test kernel from http://people.redhat.com/dzickus/el5

I am a bit confused.  Test kernels in there DO NOT contain the patch reported in
Bug 224359.  Without this (224359) patch, RHEL5.x would be totally useless for
those affected (kernel crash).

Akemi

Comment 20 Akemi Yagi 2007-06-30 19:04:29 UTC
(In reply to comment #19)
> (In reply to comment #18)
> > in 2.6.18-27.el5
> > You can download this test kernel from http://people.redhat.com/dzickus/el5
> 
> I am a bit confused.  Test kernels in there DO NOT contain the patch reported in
> Bug 224359.  

Sorry, I spoke too soon.  It seems to have the patch I referred to.




Comment 24 Don Zickus 2007-07-13 17:47:08 UTC
need to put this in MODIFIED state for the errata tool.
QE note this bz is still active due to documentation issues

Comment 33 Mike Gahagan 2007-09-19 17:41:00 UTC
Confirmed the CIFS module has been updated to 1.48aRH in 2.6.18-47.el5

Comment 35 errata-xmlrpc 2007-11-07 19:48:34 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0959.html