Bug 2386530

Summary: Helm packaging breaks external tool (helmfile)
Product: [Fedora] Fedora Reporter: Laurent Almeras <lalmeras>
Component: helmAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 42CC: go-sig, mikel
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: helm-3.18.4-3.fc43 helm-3.18.4-3.fc42 helm-3.18.4-3.fc41 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-08-06 23:46:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Laurent Almeras 2025-08-05 12:33:38 UTC
External tools like helmfile may rely on `helm version --short` output.

Current Fedora helm packaging uses raw version (i.e. 3.18.4+gd80839c) while https://github.com/helm/helm provides v-prefixed version (v3.18.4+gd80839c).

With helmfile 1.1.3 (helmfile is a popular wrapper for helm tool), this not-prefixed version trigger an errror :

```
$ helmfile diff
panic: error find helm srmver version '3.18.4+gd80839c
	': unable to find semver info in 3.18.4+gd80839c


goroutine 24 [running]:
github.com/helmfile/helmfile/pkg/helmexec.New({0x3dadf84, 0x4}, {0x0?, 0x0?}, 0xc00080a1f8, {0x0, 0x0}, {0x0, 0x0}, {0x44c4188, ...})
	/home/runner/work/helmfile/helmfile/pkg/helmexec/exec.go:123 +0x3c6
github.com/helmfile/helmfile/pkg/app.(*App).getHelm(0xc000bc26c0, 0xc000c41188)
	/home/runner/work/helmfile/helmfile/pkg/app/app.go:803 +0x25f
```

This helmfile issue was opened : https://github.com/helmfile/helmfile/issues/2107. I think Fedora package behavior is not new, but helmfile recently updates its helm version extraction, so it triggers the issue.

Even if helmfile may relax version check, I think Fedora packaging should follow official helm binary behavior, and uses a v-prefixed version.

From my package build understanding, helm.spec should be modified to use `helm.sh/helm/v3/internal/version.version=v%{version}` (v added before `%(version)`).

Reproducible: Always

Steps to Reproduce:
Install helm from Fedora package.

Install helmfile 1.1.3 (https://github.com/helmfile/helmfile/releases/tag/v1.1.3)

Run `helmfile diff` from a helmfile folder.
Actual Results:
```
$ helmfile diff
panic: error find helm srmver version '3.18.4+gd80839c
	': unable to find semver info in 3.18.4+gd80839c


goroutine 24 [running]:
github.com/helmfile/helmfile/pkg/helmexec.New({0x3dadf84, 0x4}, {0x0?, 0x0?}, 0xc00080a1f8, {0x0, 0x0}, {0x0, 0x0}, {0x44c4188, ...})
	/home/runner/work/helmfile/helmfile/pkg/helmexec/exec.go:123 +0x3c6
github.com/helmfile/helmfile/pkg/app.(*App).getHelm(0xc000bc26c0, 0xc000c41188)
	/home/runner/work/helmfile/helmfile/pkg/app/app.go:803 +0x25f
```

Expected Results:
diff is performed.

Comment 1 Mikel Olasagasti Uranga 2025-08-06 20:49:36 UTC
THANKS for such detailed report.

You're right, upstream adds `v` to the version tag and so should Fedora also. I fixed this in https://src.fedoraproject.org/rpms/helm/c/b5d71b6879ac5e386df44dcf111615f082fd2b98?branch=rawhide and will push builds and updates now.

Comment 2 Fedora Update System 2025-08-06 21:05:39 UTC
FEDORA-2025-9bdb634c3d (helm-3.18.4-3.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-9bdb634c3d

Comment 3 Fedora Update System 2025-08-06 21:09:00 UTC
FEDORA-2025-29cd044422 (helm-3.18.4-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-29cd044422

Comment 4 Fedora Update System 2025-08-06 21:09:00 UTC
FEDORA-2025-0460ca2ea1 (helm-3.18.4-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-0460ca2ea1

Comment 5 Fedora Update System 2025-08-06 23:46:17 UTC
FEDORA-2025-9bdb634c3d (helm-3.18.4-3.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2025-08-07 01:31:13 UTC
FEDORA-2025-29cd044422 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-29cd044422`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-29cd044422

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2025-08-07 02:11:25 UTC
FEDORA-2025-0460ca2ea1 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-0460ca2ea1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-0460ca2ea1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Laurent Almeras 2025-08-07 10:58:56 UTC
I applied the update with the provided command `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-29cd044422`

It fixes the original issue (error from helmfile command) as expected.

Thanks for the quick fix.

Comment 9 Fedora Update System 2025-08-15 01:04:03 UTC
FEDORA-2025-29cd044422 (helm-3.18.4-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2025-08-15 01:05:17 UTC
FEDORA-2025-0460ca2ea1 (helm-3.18.4-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.