Bug 2387212
| Summary: | Please ship esbuild JS module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Pitt <mpitt> |
| Component: | golang-github-evanw-esbuild | Assignee: | W. Michael Petullo <redhat> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 42 | CC: | go-sig, jvanderwaa, mike, redhat, vondruch |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-evanw-esbuild-0.24.2-5.fc43 golang-github-evanw-esbuild-0.24.2-3.fc42 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-11-09 03:06:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Martin Pitt
2025-08-08 07:31:57 UTC
I've created a patch to build a separate package which contains the JavaScript module, I am not 100% sure if this is how it is supposed to happen or if it can be part of "esbuild". Another issue is that Fedora's %{nodejs_sitelib} expands to the `nodejs-devel` version so it won't be compatible with nodejs20/nodejs/24 but only 22 as:
[jelle@⬢ rhel-developer-toolbox][~/projects/fedora-packages/golang-github-evanw-esbuild]%rpm -pql results_golang-github-evanw-esbuild/0.24.2/6.fc44/js-esbuild-0.24.2-6.fc44.noarch.rpm
/usr/lib/node_modules_22/esbuild/main.d.ts
/usr/lib/node_modules_22/esbuild/main.js
https://src.fedoraproject.org/fork/jelly/rpms/golang-github-evanw-esbuild/diff/rawhide..install-npm-module
Thanks Jelle!
That was a good start, but not quite sufficient yet. The goal is that this command works:
node -e 'const esbuild = require("esbuild"); esbuild.transformSync("const x=1",{loader:"js"}); console.log("esbuild works")'
It does on Debian, but not yet with your version. It's missing package.json, has wrong paths, and also requires calling esbuild *not* from /usr/bin because the module's search is... special:
var isValidBinaryPath = (x) => !!x && x !== "/usr/bin/esbuild";
I updated your initial patch, also added correct package deps, and tested it locally. Sent to https://src.fedoraproject.org/rpms/golang-github-evanw-esbuild/pull-request/13
I just merged Martin's work. See https://src.fedoraproject.org/rpms/golang-github-evanw-esbuild/pull-request/13, which should resolve this report. FEDORA-2025-39d56cce21 (golang-github-evanw-esbuild-0.24.2-5.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-39d56cce21 FEDORA-2025-39d56cce21 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-39d56cce21` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-39d56cce21 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. See https://bodhi.fedoraproject.org/updates/FEDORA-2025-39d56cce21 works fine, thanks! FEDORA-2025-df91eab101 (golang-github-evanw-esbuild-0.24.2-3.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-df91eab101 FEDORA-2025-39d56cce21 (golang-github-evanw-esbuild-0.24.2-5.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-df91eab101 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-df91eab101` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-df91eab101 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-df91eab101 (golang-github-evanw-esbuild-0.24.2-3.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |