Bug 2387446

Summary: chromium fails to build with rust-1.89.0
Product: [Fedora] Fedora Reporter: Tom Stellard <tstellar>
Component: chromiumAssignee: Than Ngo <than>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: amulhern, decathorpe, igor.raits, jchecahi, jistone, paumurph, pigpigman8686, rust-sig, spotrh, suraj.ghimire7, than, TicoTimo, yaneti
Target Milestone: ---Flags: than: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: chromium-139.0.7258.127-1.el9 chromium-139.0.7258.127-1.el10_1 chromium-139.0.7258.127-1.fc41 chromium-139.0.7258.127-1.fc42 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-08-15 11:13:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tom Stellard 2025-08-10 03:25:05 UTC
The chromium package fails to build with rust-1.89.0.  This is a regression, since the previous build with rust-1.88.0 was successful.  Here is the scratch build with rust-1.89.0: https://koji.fedoraproject.org/koji/taskinfo?taskID=135869578



Reproducible: Always

Comment 1 Fabio Valentini 2025-08-10 15:01:08 UTC
It looks like the build runs with "treat all warnings and lints as errors" turned on. I wouldn't do that. ;)

Comment 2 Josh Stone 2025-08-11 16:12:00 UTC
Right, if you deny warnings, then you're essentially opting-in to this kind of error with new versions.

In this case, it's https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint

Comment 3 Than Ngo 2025-08-11 16:47:43 UTC
decathorpe, jistone - Could you please explain more where you can see  build runs with "treat all warnings and lints as errors" turned on ? How can we turn it off?

Thank you!

Comment 4 Josh Stone 2025-08-11 17:07:03 UTC
It's the "#![deny(warnings)]" mentioned in the note:

error: hiding a lifetime that's elided elsewhere is confusing
   --> ../../third_party/rust/chromium_crates_io/vendor/qr_code-v2/src/lib.rs:219:17
    |
219 |     pub fn iter(&self) -> QrCodeIterator {
    |                 ^^^^^     -------------- the same lifetime is hidden here
    |                 |
    |                 the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
note: the lint level is defined here
   --> ../../third_party/rust/chromium_crates_io/vendor/qr_code-v2/src/lib.rs:8:9
    |
8   | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(mismatched_lifetime_syntaxes)]` implied by `#[deny(warnings)]`
help: use `'_` for type paths
    |
219 |     pub fn iter(&self) -> QrCodeIterator<'_> {
    |                                         ++++

This is in a vendored dependency, and in a typical *cargo* build it would usually add "--cap-lints=warn" when building dependencies to avoid anything but hard-errors in code you don't control. Fedora also adds the same cap to RUSTFLAGS so it would apply to everything.

However, it looks like Chromium's build system is not using cargo, and also not using any of those RUSTFLAGS, which lets this warning-as-error come through

Comment 5 Fedora Update System 2025-08-15 06:23:33 UTC
FEDORA-EPEL-2025-7f8d0718b0 (chromium-139.0.7258.127-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-7f8d0718b0

Comment 6 Than Ngo 2025-08-15 11:13:20 UTC
it's fixed in chromium-139.0.7258.127 - https://bodhi.fedoraproject.org/updates/FEDORA-2025-502faa722e
and rawhide.

Comment 7 Fedora Update System 2025-08-16 00:27:25 UTC
FEDORA-EPEL-2025-7f8d0718b0 (chromium-139.0.7258.127-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-08-16 00:40:59 UTC
FEDORA-EPEL-2025-77303504f8 (chromium-139.0.7258.127-1.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2025-08-16 01:06:08 UTC
FEDORA-2025-0ea30a8042 (chromium-139.0.7258.127-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2025-08-16 01:11:19 UTC
FEDORA-2025-502faa722e (chromium-139.0.7258.127-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.