Bug 238863
| Summary: | Review Request: avant-window-navigator - Fully customisable dock-like window navigator for GNOME | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sindre Pedersen Bjørdal <sindrepb> |
| Component: | Package Review | Assignee: | David Nielsen <gnomeuser> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gnomeuser, ihok, katzj |
| Target Milestone: | --- | Flags: | gnomeuser:
fedora-review+
kevin: fedora-cvs- |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-13 09:03:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sindre Pedersen Bjørdal
2007-05-03 14:40:02 UTC
Since nobody else has shown interest I'll give this a crack to get practice:
BAD:
* missing BuildRequires on desktop-file-utils
* missing BuildRequires on GConf2-devel
* Replace [NAME] with %{name} in the schema handling.
Updated: - Add missing BRs - Fix gconf scriplets Spec URL: http://folk.ntnu.no/sindrb/packages/avant-window-navigator.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/avant-window-navigator-0.1.1-2.fc7.src.rpm 8de5ca6b7ea707ae5298526c98799abf avant-window-navigator-0.1.1-2.tar.gz
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages (except item in Bad section)
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Builds in mock.
* rpmlint is quiet
Likely bad:
* owns %{_bindir}/*
Not sure if this is permissable at least I can't find any other packages that
does this.
Aside that I can't find any problems
The directory %{_datadir}/avant-window-navigator/ doesn't seem
to be owned by any package.
Updated:
- Own %%{_datadir}/avant-window-navigator
Spec URL: http://folk.ntnu.no/sindrb/packages/avant-window-navigator.spec
SRPM URL:
http://folk.ntnu.no/sindrb/packages/avant-window-navigator-0.1.1-3.fc7.src.rpm
This seems sane, let's call it APPROVED *** Bug 245385 has been marked as a duplicate of this bug. *** New Package CVS Request ======================= Package Name: avant-window-manager Short Description: Fully customisable dock-like window navigator for GNOME Owners: foolish Branches: F-7 FC-6 Sorry, botched the name. It should be avant-window-navigator. New Package CVS Request ======================= Package Name: avant-window-navigator Short Description: Fully customisable dock-like window navigator for GNOME Owners: foolish Branches: F-7 FC-6 cvs done (I hope). You may also have to modify your Makefile to have the right package name when you check in. Closing as now this is on rawhide... Package Change Request ====================== Package Name: avant-window-navigitor Updated Fedora Owners: sindrepb, ngompa I don't see user 'ngompa' in cvsextras. Can you check the Fedora Account system username and try again? |