Bug 2390079
| Summary: | git-core subpackage now depends on perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dusty Mabe <dustymabe> |
| Component: | git | Assignee: | Ondřej Pohořelský <opohorel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | awilliam, besser82, johannes, jonathan, miabbott, mizdebsk, opohorel, pstodulk, yaneti |
| Target Milestone: | --- | Flags: | opohorel:
mirror+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://github.com/coreos/fedora-coreos-tracker/issues/2011 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-08-21 18:38:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dusty Mabe
2025-08-21 12:19:28 UTC
find templates -type f -name "*sample" | xargs chmod -x is enough to strip the perl dep. Personally I would have anything *.sample in docs and not the core package Hah, hi Dusty, you win this round. :P openQA actually caught this, but I couldn't figure out what was going on and decided it was a blip - all I knew is that it pulled in the older git from the rawhide repo instead of the newer one from the advisory repo, it doesn't tell you *why* it does that and I couldn't work it out yesterday. Now we know! Indeed, all openQA Silverblue ostree build tests now fail on this, and all Atomic desktop builds in today's compose failed too - https://pagure.io/releng/failed-composes/issue/8538 . Adding this to the spec fixes it:
# Don't generate deps from the sample hooks (to avoid perl deps in core)
%global __requires_exclude_from ^%{_datadir}/git-core/templates/hooks/.*sample$
that tells RPM to skip any files matching that regex when auto-generating requirements. See https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/ .
Even if we do decide to move all the sample hooks to another package, I think it's a good idea to *also* add that line, as it doesn't seem right for *whichever* package they wind up in to have any deps which are *only* required to run sample hooks.
Fixed now, F43 and F44 updates are both stable. The bug never made it to F41 or F42. |