Bug 2391023
| Summary: | fedpkg: argcomplete script dumped to terminal on tab press | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | fedpkg | Assignee: | Ondřej Nosek <onosek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | chris, gui1ty, igor.raits, lsedlar, maxwell, mhroncok, msrb, onosek, python-packagers-sig, qcxhome, steve.traylen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | fedpkg-1.47-2.fc43 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-12-14 01:00:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This appears to be an issue with fedpkg's implementation of argcomplete. Since fedpkg is using rpkg's ArgumentParser I'm not sure if that needs to be fixed in fedpkg or rpkg.
With pytest, which also uses argcomplete, auto completion works fine in the same context:
for i in {1..10}; do pytest --run[TAB]
I'm not sure how to debug this further. Setting _ARC_DEBUG=1 doesn't appear to work inside the for loop construct. It just shows the Bash completion script without any debug information (or simply completes the argument in case of pytest).
It turns out fedpkg-completion supplies a completion script (/usr/share/bash-completion/completions/fedpkg.bash) that appears to fail when argcomplete falls back to readline. The completion script is a single line: register-python-argcomplete fedpkg That doesn't work and results in the output of 'register-python-argcomplete fedpkg' being dumped in the terminal. It needs to be either 'eval "$(register-python-argcomplete fedpkg)"' as per argcomplete documentation [1], or, in line with other packages (e.g. fedrq) the output of 'register-python-argcomplete fedpkg'. I tried both. Though, putting the static completion script into that file seems to be the better approach and probably speeds things up a little as well. [1] https://kislyuk.github.io/argcomplete/#synopsis Ondřej, would you please respond to the proposed PR? FEDORA-2025-3a77b42326 (fedpkg-1.47-2.fc43 and rpkg-1.69-3.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3a77b42326 FEDORA-2025-3a77b42326 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-3a77b42326` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-3a77b42326 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-3a77b42326 (fedpkg-1.47-2.fc43 and rpkg-1.69-4.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |
With: python3-argcomplete-3.6.2-6.fc44.noarch bash-completion-2.16-2.fc43.noarch bash-5.3.0-2.fc43.x86_64 fedpkg-1.46-6.fc44.noarch In a fresh Fedora rawhide container. However, also happens on my Fedora 41 with: python3-argcomplete-3.6.2-2.fc41.noarch bash-completion-2.16-1.fc41.noarch bash-5.2.32-1.fc41.x86_64 fedpkg-1.46-4.fc41.noarch Put this in the Bash prompt: for i in {1..10}; do fedpkg --release f43 build --nowait --scratch --f[CURSOR HERE] ; done Press tab. The output of the Bash completions script floods the terminal. Expected behavior: --fail-fast is completed.