Bug 239155 (perl-Class-Gomor)
| Summary: | Review Request: perl-Class-Gomor - Another class and object builder | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sindre Pedersen Bjørdal <sindrepb> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Keywords: | Reopened |
| Target Milestone: | --- | Flags: | cweyl:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-01 18:01:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 239156, 239158 | ||
|
Description
Sindre Pedersen Bjørdal
2007-05-05 13:16:32 UTC
Missing BR's on perl(Test::More), perl(ExtUtils::MakeMaker), perl(Test::Pod), perl(Test::Pod::Coverage) [though the last one isn't a blocker]. There's an examples/ directory, why not include it? For the purposes of this review, I've added it to %doc. Add examples/ to %doc and the missing BR's, and I'll approve :) +source files match upstream: 53f611cd26439fa35ce1e84d700d777a Class-Gomor-1.01.tar.gz 53f611cd26439fa35ce1e84d700d777a ../Class-Gomor-1.01.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text included in package. + latest version is being packaged. X BuildRequires are proper. + compiler flags are appropriate. (noarch) + %clean is present. + package installs properly + rpmlint is silent. + final provides and requires are sane: ** perl-Class-Gomor-1.01-1.fc6.noarch.rpm == rpmlint == provides perl(Class::Gomor) = 1.01 perl(Class::Gomor::Array) = 1.01 perl(Class::Gomor::Hash) = 1.01 perl-Class-Gomor = 1.01-0.1.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Class::Gomor) perl(Data::Dumper) perl(Exporter) perl(strict) perl(warnings) + %check is present and all tests pass: All tests successful. Files=12, Tests=16, 1 wallclock secs ( 0.60 cusr + 0.18 csys = 0.78 CPU) + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. Updated: SPEC: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Class-Gomor.spec SRPM: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Class-Gomor-1.01-2.fc7.src.rpm Changes: - Add missing BRs - Add examples dir to %%doc rpmlint is silent here, but it was silent before as well. APPROVED New Package CVS Request ======================= Package Name: perl-Class-Gomor Short Description: Another class and object builder Owners: foolish Branches: FC-5 FC-6 EL-4 EL-5 InitialCC: jaa Seems the F7 branch wasn't created during merge, please add it. New Package CVS Request ======================= Package Name: perl-Class-Gomor Short Description: Another class and object builder Owners: foolish Branches: F-7 Done. Please don't open tickets just to make CVS requests. |