Bug 2392382
| Summary: | Review Request: perl-Sys-HostIP - Try extra hard to get IP address related info | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | ppisar:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://metacpan.org/dist/Sys-HostIP | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-09-12 19:26:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2392368 | ||
|
Description
Jitka Plesnikova
2025-09-01 13:02:57 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9512299 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2392382-perl-sys-hostip/fedora-rawhide-x86_64/09512299-perl-Sys-HostIP/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. URL and Source0 address are usable. Ok.
Source0 archive (SHA-512 2676c78caf718d32f328e3e8f1886dfefff53d862617f08d7d884c84c6e27b8a26fcb3d46faba8f68e99600332b161ad3d8dc73372da7450cc86818ff8e61f9a) is original. Ok.
Summary verified from lib/Sys/HostIP.pm. OK.
TODO: Spell `info' in full as `information'.
Description verified from lib/Sys/HostIP.pm. OK.
License verified from LICENSE, lib/Sys/HostIP.pm, README. Ok.
No XS code, noarch BuildArch is Ok.
TODO: You can remove a duplicate NO_PACKLIST=1 argument (perl-Sys-HostIP.spec:46).
All tests pass. Ok.
$ rpmlint perl-Sys-HostIP.spec ../SRPMS/perl-Sys-HostIP-2.120-1.fc44.src.rpm ../RPMS/noarch/perl-Sys-HostIP-2.120-1.fc44.noarch.rpm
======================================== rpmlint session starts =======================================
rpmlint: 2.7.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
perl-Sys-HostIP.noarch: E: spelling-error ('ifconfig', '%description -l en_US ifconfig -> configure')
perl-Sys-HostIP.noarch: E: spelling-error ('ipconfig', '%description -l en_US ipconfig -> configure')
perl-Sys-HostIP.src: E: spelling-error ('ifconfig', '%description -l en_US ifconfig -> configure')
perl-Sys-HostIP.src: E: spelling-error ('ipconfig', '%description -l en_US ipconfig -> configure')
perl-Sys-HostIP.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Sys-HostIP/LICENSE
=== 2 packages and 1 specfiles checked; 5 errors, 0 warnings, 6 filtered, 5 badness; has taken 0.4 s ==
rpmlint is OK.
$ rpm -q -lv -p ../RPMS/noarch/perl-Sys-HostIP-2.120-1.fc44.noarch.rpm
drwxr-xr-x 2 root root 0 Sep 1 02:00 /usr/share/doc/perl-Sys-HostIP
-rw-r--r-- 1 root root 4696 Aug 29 2019 /usr/share/doc/perl-Sys-HostIP/Changes
-rw-r--r-- 1 root root 373 Aug 29 2019 /usr/share/doc/perl-Sys-HostIP/README
drwxr-xr-x 2 root root 0 Sep 1 02:00 /usr/share/licenses/perl-Sys-HostIP
-rw-r--r-- 1 root root 18337 Aug 29 2019 /usr/share/licenses/perl-Sys-HostIP/LICENSE
-rw-r--r-- 1 root root 2374 Sep 1 02:00 /usr/share/man/man3/Sys::HostIP.3pm.gz
drwxr-xr-x 2 root root 0 Sep 1 02:00 /usr/share/perl5/vendor_perl/Sys
-rw-r--r-- 1 root root 12589 Aug 29 2019 /usr/share/perl5/vendor_perl/Sys/HostIP.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Sys-HostIP-2.120-1.fc44.noarch.rpm | sort -f | uniq -c
1 net-tools
1 perl(Carp)
1 perl(Exporter)
1 perl(File::Basename)
1 perl(parent)
1 perl(strict)
1 perl(warnings)
1 perl-libs
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Sys-HostIP-2.120-1.fc44.noarch.rpm | sort -f | uniq -c
1 perl(Sys::HostIP) = 2.120
1 perl-Sys-HostIP = 2.120-1.fc44
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Sys-HostIP-2.120-1.fc44.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 44 <https://koji.fedoraproject.org/koji/taskinfo?taskID=136656407>. Ok.
The package is in line with Fedora and Perl packaging guidelines.
Please correct the TODO items before building this package.
The package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Sys-HostIP FEDORA-2025-3f95080b8f (perl-Sys-HostIP-2.120-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3f95080b8f FEDORA-2025-3f95080b8f has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-3f95080b8f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-3f95080b8f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-3f95080b8f (perl-Sys-HostIP-2.120-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |