Bug 2392879

upstream bug: https://bugzilla.samba.org/show_bug.cgi?id=15904

Fedora Rawhide got PCP 7.0.0 couple days ago, Samba does not build anymore due to it when --enable-pmda is specified.

../../ctdb/utils/pmda/pmda_ctdb.c: In function ‘pmda_ctdb_fetch’:
../../ctdb/utils/pmda/pmda_ctdb.c:475:44: error: passing argument 3 of ‘pmdaFetch’ from incompatible pointer type [-Wincompatible-pointer-types]
  475 |         ret = pmdaFetch(numpmid, pmidlist, resp, pmda);
      |                                            ^~~~
      |                                            |
      |                                            pmResult **
In file included from ../../ctdb/utils/pmda/pmda_ctdb.c:35:
/usr/include/pcp/pmda.h:571:45: note: expected ‘pmResult_v2 **’ but argument is of type ‘pmResult **’
  571 | PMDA_CALL extern int pmdaFetch(int, pmID *, pmdaResult **, pmdaExt *);
      |                                             ^
../../ctdb/utils/pmda/pmda_ctdb.c: In function ‘pmda_ctdb_init’:
../../ctdb/utils/pmda/pmda_ctdb.c:494:31: error: assignment to ‘int (*)(int,  pmID *, pmResult_v2 **, pmdaExt *)’ {aka ‘int (*)(int,  unsigned int *, pmResult_v2 **, pmdaExt *)’} from incompatible pointer type ‘int (*)(int,  pmID *, pmResult **, pmdaExt *)’ {aka ‘int (*)(int,  unsigned int *, pmResult **, pmdaExt *)’} [-Wincompatible-pointer-types]
  494 |         dp->version.two.fetch = pmda_ctdb_fetch;
      |                               ^
../../ctdb/utils/pmda/pmda_ctdb.c:453:1: note: ‘pmda_ctdb_fetch’ declared here
  453 | pmda_ctdb_fetch(int numpmid, pmID pmidlist[], pmResult **resp, pmdaExt *pmda)
      | ^~~~~~~~~~~~~~~

https://github.com/performancecopilot/pcp/commit/b5de2321db50741b0d34138d48faaf5c490a8755

In Rawhide scratch builds I get the following reported:

Checking for header pcp/pmapi.h                 : yes 
Checking for header pcp/impl.h                  : yes 
Checking for header pcp/pmda.h                  : yes 
Checking for library pcp                        : yes 
Checking for pmProgname in pcp                  : not found 
Checking for library pcp_pmda                   : yes 
Checking for pmdaDaemon in pcp_pmda             : ok 
Checking for __pmID_int                         : not found 
Building with PMDA support

So __pmID_int was hidden and some API did change their definitions.

We will disable PCP support until it is fixed upstream because PCP 7.0.0 is already in Rawhide and is on track to get to F43.

Reproducible: Always