Bug 239495

Kevin, David is out at the summit, so I'll doubt he'll have time to do this in
the near future. Do you have a spec file patch for this ?

Saw -kde subpkg appear in cvs, but it currently contains:
Requires: %{name} ...
which isn't required, nor desired (ie, we don't want all of redhat-artwork 
pulled onto the kde livecd).  

All you need to do is omit this from the spec:
# save some space
%if "%{?kde}" == "1"
pushd $RPM_BUILD_ROOT%{_datadir}/apps/kdm/themes/FedoraFlyingHigh
  rm -f background.jpg
  ln -s ../../../../gdm/themes/FedoraFlyingHigh/background.jpg .
popd
%endif

Ah, and (borred from former redhat-artwork-kde):
%files kde
+%defattr(-,root,root,-)
-%{_libdir}/kde3
+%{_libdir}/kde3/*
+%{_datadir}/apps/kdisplay/color-schemes/Bluecurve.kcsrc
%{_datadir}/apps/kdm/themes/Bluecurve
+%{_datadir}/apps/kdm/themes/Fedora*
+%{_datadir}/apps/kstyle/themes/Bluecurve.themerc
+%{_datadir}/apps/kwin/bluecurve.desktop

You may want to consider adding:
%_libdir}/%{qtdir}
to -kde subpackage as well.

with that, and kde being split out, perhaps you could now seriously consider 
omitting:
# we don't want to require gtk/qt
Autoreq: 0

(I suppose in a perfect world, there would exist -gtk subpkg as well).

> Saw -kde subpkg appear in cvs, but it currently contains:
> Requires: %{name} ...
> which isn't required, nor desired (ie, we don't want all of redhat-artwork
> pulled onto the kde livecd).

It is desired:
* The Bluecurve Qt theme is in the base package, as are the Bluecurve icons 
(and Echo, but that doesn't properly work with KDE yet anyway).
* The KDM theme symlinks the background image to the GDM theme.
My package had Requires: redhat-artwork too.

As for %{_libdir}/kde3 being owned, that's because autoreq is disabled, so 
redhat-artwork can't rely on kdelibs actually being installed, and we don't 
want an unowned directory lieing around.

These ones are needed though:
+%{_datadir}/apps/kdisplay/color-schemes/Bluecurve.kcsrc
%{_datadir}/apps/kdm/themes/Bluecurve
+%{_datadir}/apps/kdm/themes/Fedora*
+%{_datadir}/apps/kstyle/themes/Bluecurve.themerc
+%{_datadir}/apps/kwin/bluecurve.desktop

This actually failed the build:
https://koji.fedoraproject.org/koji/getfile?taskID=5445&name=build.log
Koji is doing its job there. ;-) There's also /usr/share/icons/Fedora listed 
twice which the build rightfully complained about.

Created attachment 154452 [details]
Patch against redhat-artwork.spec in CVS

I attached a patch to fix the redhat-artwork.spec currently in CVS so it should
actually build:

-%dir %{_datadir}/icons/Fedora
-%{_datadir}/icons/Fedora/*
already covered by %{_datadir}/icons/* before, causes the duplicate file
errors.

+%{_datadir}/apps/kdisplay/color-schemes/Bluecurve.kcsrc
 %{_datadir}/apps/kdm/themes/Bluecurve
+%{_datadir}/apps/kdm/themes/Fedora*
+%{_datadir}/apps/kstyle/themes/Bluecurve.themerc
+%{_datadir}/apps/kwin/bluecurve.desktop
as discussed before.

Will be fixed in 7.0.0-3.fc7

Thanks, no biggie, but could you move the qt bits to -kde too:
%{_libdir}/%{qtdir}/etc/settings/*
%{_libdir}/%{qtdir}/plugins/styles/bluecurve.la

Thanks for the fixes (I see you fixed Bug 239644 too), is releng already on the 
loop?

7.0.0-3.fc7 has been tagged f7-final by Release Engineering now.

Whoops, we forgot to add the:
%defattr(-,root,root,-)
under %files kde. (This is partly my fault for forgetting it in my patch.)

fixed in 7.0.0-4.fc7