Bug 239526
| Summary: | Review Request: python-gammu - Python bindings for Gammu | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Lamien <lxtnow> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-13 01:49:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 239525 | ||
| Bug Blocks: | 239527 | ||
|
Description
Xavier Lamien
2007-05-09 06:36:24 UTC
So this package is also having similar rpmlint output like gammu have. Got spurious-executable-perm and doc-file-depencecy with rpmlint 0.80 version. Any comments on why both warnings should be ignored? those are exemples script which could be check for extras use (such as manage smsbackup). upstream isn't more explicit about them... :( but here rpmlint is showing doc-file-dependency warning... Is gammu-python really using these scripts or its for end-user to explicitly use them? if that is then you can chmod 644 to those scripts. It's typically for end-user and sure these can be set to 0644. i actually fix that but i need to import first new gammu release before add the updated release of python-gammu which require gammu-1.10.7 to be able to build. Well, Here is the updated release 0.20 with its fix. you'll find out srpm, spec and build.log files from link below. http://download.tuxfamily.org/lxtnow/extras/gammu ping : Parag ? will do review by tomorrow rpmlint on SRPM reports W: python-gammu mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 4) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. you can correct this at time of cvs import. Review: + package builds in mock (development i386). - rpmlint is NOT silent for SRPM + rpmlint is silent for RPM. + source files match upstream url a2470a7336286805d9698b3d67bb23c1 python-gammu-0.20.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Provides: Core.so + Requires: gammu libGammu.so.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libm.so.6 libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH) APPROVED Don't forget to solve rpmlint warning on SRPM. I will fix that before request CVSsync, thanks Parag Done, New Package CVS Request ======================= Package Name: python-gammu Short Description: Python bindings for Gammu Owners: lxtnow Branches: FC-5 FC-6 F-7 EL-4 EL-5 Devel InitialCC: CVS done. imported and built. Thanks to all |