Bug 2395643
| Summary: | Review Request: rust-ngx - FFI bindings to NGINX | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Aleksei Bavshin <alebastr89> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/ngx | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-06-30 19:34:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2395641 | ||
| Bug Blocks: | 2395644 | ||
|
Description
Aleksei Bavshin
2025-09-16 05:50:37 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9558492 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395643-rust-ngx/fedora-rawhide-x86_64/09558492-rust-ngx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/9953406 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395643-rust-ngx/fedora-rawhide-x86_64/09953406-rust-ngx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > Problem: nothing provides requested (crate(nginx-sys/default) >= 0.5.0 with crate(nginx-sys/default) < 0.6.0~)
[fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/10627551 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395643-rust-ngx/fedora-rawhide-x86_64/10627551-rust-ngx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good to me! One thing that is a bit confusing is this change that you apply to Cargo.toml: """ - "LICENSE", + "/LICENSE", """ Both should do the same thing in this case, since there is only one file named "LICENSE" in the tarball? Upstream has also released 0.5.1 recently, it would be nice if you could update to that version. Looking at the diff from 0.5.0, it should be a straightforward backwards compatible update. === Package was generated with rust2rpm, simplifying the review. The downstream patches are well documented and justified. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged: version 0.5.0 is packaged, latest is 0.5.1 The difference looks very small, so this can just be updated after import. ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ngx Monitoring: Anitya project is accessible by this link `https://release-monitoring.org/project/390950` you can modify it manually. Package was created in Anitya Thanks for the review! (In reply to Fabio Valentini from comment #7) > Package looks good to me! > > One thing that is a bit confusing is this change that you apply to > Cargo.toml: > > """ > - "LICENSE", > + "/LICENSE", > """ > > Both should do the same thing in this case, since there is only one file > named "LICENSE" in the tarball? There's also %{_nginx_buildsrcdir}/LICENSE (BSD-3-Clause from the nginx sources) that will be picked by cargo install without the change. I'll add this to the patch comment. The change is not worth upstreaming, because it deals with the weirdness of %nginx_modconfigure macro implementation. FEDORA-2026-651aae0170 (rust-ngx-0.5.1-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-651aae0170 FEDORA-2026-651aae0170 (rust-ngx-0.5.1-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. |