Bug 2397174
| Summary: | Review Request: perl-Data-Censor - Censor sensitive stuff in a data structure | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | ppisar:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://metacpan.org/dist/Data-Censor | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Data-Censor-0.04-2.fc44 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-10-12 08:33:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2395583 | ||
|
Description
Emmanuel Seyman
2025-09-21 16:40:47 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9587607 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397174-perl-data-censor/fedora-rawhide-x86_64/09587607-perl-Data-Censor/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. URL and Source0 addresses are usable. Ok. TODO: Use https://cpan.metacpan.org/authors/id/B/BI/BIGPRESH/Data-Censor-%{version}.tar.gz as Sourc0 URL. Source0 archive (SHA512: de24ec34f4f433795b2cbb0a5ff6191a972f4f9684964a3f442e75588c3a634a66734983d5d9b3c7f43a5470aa1dd278fba7360a84b23eec9885e0133fd5c51d) is original. Ok. Licenses verified in README, lib/Data/Censor.pm, and Makefile.PL. Ok. Summary verified in lib/Data/Censor.pm. Ok. Description is Ok. No XS code, noarch BuildArch is Ok. Build dependencies are Ok. TODO: Unset RELEASE_TESTING environment variable in %check phase to make the tests more reproducible (t/manifest.t:7). All tests pass. Ok. $ rpmlint perl-Data-Censor.spec ../SRPMS/perl-Data-Censor-0.04-1.fc44.src.rpm ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm drwxr-xr-x 2 root root 0 Sep 21 02:00 /usr/share/doc/perl-Data-Censor -rw-r--r-- 1 root root 420 Jun 19 10:40 /usr/share/doc/perl-Data-Censor/Changes -rw-r--r-- 1 root root 5665 Mar 12 2014 /usr/share/doc/perl-Data-Censor/README -rw-r--r-- 1 root root 3280 Sep 21 02:00 /usr/share/man/man3/Data::Censor.3pm.gz drwxr-xr-x 2 root root 0 Sep 21 02:00 /usr/share/perl5/vendor_perl/Data -rw-r--r-- 1 root root 8152 Jun 19 10:38 /usr/share/perl5/vendor_perl/Data/Censor.pm File layout an permission are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.6.0 1 perl(Carp) 1 perl(Ref::Util) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm | sort -f | uniq -c 1 perl(Data::Censor) = 0.04 1 perl-Data-Censor = 0.04-1.fc44 Binary provides are Ok. $ resolvedeps f44-build ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=137491554). Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. This package is APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Censor (In reply to Petr Pisar from comment #2) > > TODO: Use > https://cpan.metacpan.org/authors/id/B/BI/BIGPRESH/Data-Censor-%{version}. > tar.gz as Sourc0 URL. Done. > TODO: Unset RELEASE_TESTING environment variable in %check phase to make the > tests more reproducible (t/manifest.t:7). Done. > Please consider fixing the TODO items before building this package. Spec URL: https://eseyman.fedorapeople.org/perl-Data-Censor/perl-Data-Censor.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Data-Censor/perl-Data-Censor-0.04-2.fc42.src.rpm > This package is APPROVED. Thank you for the review, Petr. Repo requested. Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=2832201 |