Bug 239775
| Summary: | Zaptel %{fedora} macro usage isn't safe | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Saou <matthias> |
| Component: | zaptel | Assignee: | Jeffrey C. Ollie <jeff> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-03 05:43:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Removed usage of the %{fedora} macro in latest package.
|
The current 1.4.2.1-1 zaptel package uses the %{fedora} macro in ways that will break if it isn't defined. This isn't a major problem in Fedora land, but does break EPEL builds of the package "as-is", which is too bad. I'd suggest two options : - Add a single line at the top of the file with : %{!?fedora:%define fedora 7} - Change the %if tests to become valid even when %{fedora} isn't defined : %if %{!?fedora:7}%{fedora} > 5 This would make the build without %{fedora} defined behave the same as when it's set to 7. Feel free to ignore this if you don't like the idea, but I hope you do consider making some changes ;-)