Bug 2397825
| Summary: | Review Request: texlive-eq-save - Save exerquiz quizzes and resume | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <spotrh> | ||||
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | msuchy, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | msuchy:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://tug.org/texlive/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2026-02-07 13:55:14 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2025-09-24 14:50:28 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9597672 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397825-texlive-eq-save/fedora-rawhide-x86_64/09597672-texlive-eq-save/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. You may want to fix:
texlive-eq-save.spec:18: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 18)
You can document in comment how you get:
Source2: texlive-licenses.tar.xz
The %doc is big - 95% of the package. Maybe create -doc subpackage. On the other hand the package has only 357 KB, so it is not a big deal.
A blocker for review:
tar -xf %{SOURCE0} -C %{buildroot}%{_texmf_main}
tar -xf %{SOURCE1} -C %{buildroot}%{_texmf_main}
Please move the extraction to %prep and in %install do just `cp -a`.
I will move the extraction for these smaller packages, but there is a significant buildtime cost (and added spec complexity) to copying the tex components twice (once in %build, again in %install) when building the larger collection packages, and I do not think it is worth changing them there. To your point on the docs... in the past, there were -doc subpackages for most of the texlive component packages and it scaled poorly. rpm has mechanisms to install without files marked as %doc and that is a far better solution for most texlive components (and it makes the packaging so much cleaner). Only in egregious cases where the docs are massive (texlive-context-doc) do I force a -doc subpackage. New SPEC: https://spot.fedorapeople.org/tl2025/texlive-eq-save.spec New SRPM: https://spot.fedorapeople.org/tl2025/texlive-eq-save-svn299-2.fc44.src.rpm Created attachment 2108238 [details]
The .spec file difference from Copr build 9597672 to 9636924
Copr build: https://copr.fedorainfracloud.org/coprs/build/9636924 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397825-texlive-eq-save/fedora-rawhide-x86_64/09636924-texlive-eq-save/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. If cp is costly, then I think you can `mv`. My point is that after %prep should be the sources extracted so various tools can analyze it after `rpmbuild -bp`. With the -doc subpackages I think it is still worth doing. But I will not block the review on this. Especially when this is "just" split of existing package and just copy current state. APPROVED. Please reset and re-enable the review flag here, so I can start making these packages in rawhide. Apologies for the extra work, I didn't realize there was a time-limit. updated The Pagure repository was created at https://src.fedoraproject.org/rpms/texlive-eq-save |