Bug 2397826
| Summary: | Review Request: texlive-mathtime-ltx - LaTeX macros for using MathTime and MathTime Plus | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <spotrh> | ||||
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | msuchy, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | msuchy:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://tug.org/texlive/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2025-09-24 14:52:27 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9597677 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397826-texlive-mathtime-ltx/fedora-rawhide-x86_64/09597677-texlive-mathtime-ltx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. You may want to fix:
texlive-mathtime-ltx.spec:18: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 18)
You may document in a comment how you created `Source2: texlive-licenses.tar.xz`
The above is not a blocker. But the below is a blocker:
> %install
> tar -xf %{SOURCE0} -C %{buildroot}%{_texmf_main}
> tar -xf %{SOURCE1} -C %{buildroot}%{_texmf_main}
Please move the extraction to %prep and %install do just `cp -a` of these files.
I will move the extraction for these smaller packages, but there is a significant buildtime cost (and added spec complexity) to copying the tex components twice (once in %build, again in %install) when building the larger collection packages, and I do not think it is worth changing them there. New SPEC: https://spot.fedorapeople.org/tl2025/texlive-mathtime-ltx.spec New SRPM: https://spot.fedorapeople.org/tl2025/texlive-mathtime-ltx-svn362-2.fc44.src.rpm Created attachment 2108237 [details]
The .spec file difference from Copr build 9597677 to 9636887
Copr build: https://copr.fedorainfracloud.org/coprs/build/9636887 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397826-texlive-mathtime-ltx/fedora-rawhide-x86_64/09636887-texlive-mathtime-ltx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. APPROVED |