Bug 2398191

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9601075
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398191-checkmake/fedora-rawhide-x86_64/09601075-checkmake/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I patched out the use of git in checkmate's Makefile, since using git to gather a name and email address in the context of the Fedora build system does not work.

> Patch0:         checkmake-0.2.2-remove-git-from-makefile.patch
> (...)
> make

You could just skip this and export GO_LDFLAGS and use regular %gobuild. Something like:

export GO_LDFLAGS="-X main.version=%{version} \
                   -X main.buildTime=$(date -u -d@$SOURCE_DATE_EPOCH +"%Y-%m-%dT%H:%M:%SZ") \
                   -X main.builder=Fedora"
%gobuild -o %{gobuilddir}/bin/checkmake ./cmd/checkmake

The main.goversion GO_LDFLAG would be missing in that proposal, but I don't have time at the moment to check the correct way to set it.

You would miss the pandoc part, but would to manually run this Makefile rule:

%.1: man/man1/%.1.md
	sed "s/REPLACE_DATE/$(BUILDDATE)/" $< | pandoc -s -t man -o $@

> %doc man/man1/checkmake.1.md

If you require pandoc to create the manpage, it would make sense to install it and not the md file

Spec URL: https://www.flyn.org/SRPMS/checkmake.spec
SRPM URL: https://www.flyn.org/SRPMS/checkmake-0.2.2-1.fc43.src.rpm

Adjusted according to Mikel's suggestions.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9601952
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398191-checkmake/fedora-rawhide-x86_64/09601952-checkmake/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to W. Michael Petullo from comment #2)
> I patched out the use of git in checkmate's Makefile, since using git to
> gather a name and email address in the context of the Fedora build system
> does not work.


Right, good observation:  this anti-pattern generally breaks the build from release tarballs instead of building from a git checkout.
To make things worse, git is additionally   used to determine the version.


The upstream Makefile should be changed to work outside a git checkout.

 (In reply to W. Michael Petullo from comment #4)
> Spec URL: https://www.flyn.org/SRPMS/checkmake.spec
> SRPM URL: https://www.flyn.org/SRPMS/checkmake-0.2.2-1.fc43.src.rpm
> 
> Adjusted according to Mikel's suggestions.


Trying to locally rebuild fails and I see this:


RPM build warnings:
    File listed twice: /usr/share/licenses/checkmake

RPM build errors:
    Empty %files file /home/obnox/rpmbuild/BUILD/checkmake-0.2.2-build/checkmake-0.2.2/debugsourcefiles.list

(In reply to Michael Adam from comment #7)
> Trying to locally rebuild fails and I see this:
> 
> 
> RPM build warnings:
>     File listed twice: /usr/share/licenses/checkmake
> 
> RPM build errors:
>     Empty %files file
> /home/obnox/rpmbuild/BUILD/checkmake-0.2.2-build/checkmake-0.2.2/
> debugsourcefiles.list


This failure only happens when I use rpmbuild directly.

running 'mock --rebuild',  it builds just fine.

And the resulting rpm installs and works without problems.

Golang Package Review
==============

This package was generated using go2rpm and Go Vendor Tools, which simplifies
the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.
- [x] GO_LDFLAGS are set correctly.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

The Pagure repository was created at https://src.fedoraproject.org/rpms/checkmake

FEDORA-2025-93a7121cfc (checkmake-0.2.2-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-93a7121cfc

FEDORA-2025-93a7121cfc (checkmake-0.2.2-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.