Bug 2400111

Summary: Review Request: rust-reqsign-command-execute-tokio - Tokio-based command execution implementation for reqsign
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/reqsign-command-execute-tokio
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-10-02 12:37:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2400096    
Bug Blocks: 2400195, 2400218    
Attachments:
Description Flags
Configuration file for rust2rpm none

Description Ben Beasley 2025-09-29 12:52:07 UTC
Created attachment 2107959 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-reqsign-command-execute-tokio.spec
SRPM URL: https://music.fedorapeople.org/rust-reqsign-command-execute-tokio-1.0.0-1.fc42.src.rpm
Description: Tokio-based command execution implementation for reqsign.
Fedora Account System Username: music

This is a new indirect dependency for uv 0.8.21 and later.

Comment 1 Fedora Review Service 2025-09-29 12:54:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9628127
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2400111-rust-reqsign-command-execute-tokio/fedora-rawhide-x86_64/09628127-rust-reqsign-command-execute-tokio/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2025-09-29 12:54:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9628128
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2400111-rust-reqsign-command-execute-tokio/fedora-rawhide-x86_64/09628128-rust-reqsign-command-execute-tokio/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2025-10-02 11:44:35 UTC
Looks like the repository URL is wrong in the Cargo.toml metadata:
https://github.com/Xuanwo/reqsign

This is a redirect to:
https://github.com/apache/opendal-reqsign

But that's not a problem for the package.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files (included from upstream, PR to include in published crates submitted and merged upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 4 Ben Beasley 2025-10-02 12:14:00 UTC
Thank you for the review.

(In reply to Fabio Valentini from comment #3)
> Looks like the repository URL is wrong in the Cargo.toml metadata:
> https://github.com/Xuanwo/reqsign
> 
> This is a redirect to:
> https://github.com/apache/opendal-reqsign
> 
> But that's not a problem for the package.

Hmm, I noticed that too. It seems like upstream has now handled it in https://github.com/apache/opendal-reqsign/commit/6a46ce475964ef0e887320e1c77b4d7c8d9ddbe1, and we can expect new releases based on https://github.com/apache/opendal-reqsign/commit/282b5dc716af0f788c50802229652d342e97a33e soon.

https://release-monitoring.org/project/385430/

Comment 5 Fedora Admin user for bugzilla script actions 2025-10-02 12:14:39 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-reqsign-command-execute-tokio

Comment 6 Fedora Update System 2025-10-02 12:33:29 UTC
FEDORA-2025-b9512005e4 (rust-reqsign-command-execute-tokio-1.0.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b9512005e4

Comment 7 Fedora Update System 2025-10-02 12:37:28 UTC
FEDORA-2025-b9512005e4 (rust-reqsign-command-execute-tokio-1.0.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.