Bug 2401447

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
     BSD 3-Clause License". 35 files have unknown license. Detailed output
     of licensecheck in /home/fedora-packaging/reviews/python-
     ipcqueue/2401447-python-ipcqueue/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/python3.14,
     /usr/lib64/python3.14/site-packages
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2122 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: python3-ipcqueue-0.9.7-1.fc44.x86_64.rpm
          python-ipcqueue-0.9.7-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpqpjcx3h7')]
checks: 32, packages: 2

python-ipcqueue.src: E: spelling-error ('unlinked', '%description -l en_US unlinked -> unlined, unlike')
python3-ipcqueue.x86_64: E: spelling-error ('unlinked', '%description -l en_US unlinked -> unlined, unlike')
 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 7 filtered, 2 badness; has taken 0.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-ipcqueue.x86_64: E: spelling-error ('unlinked', '%description -l en_US unlinked -> unlined, unlike')
 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.2 s 



Unversioned so-files
--------------------
python3-ipcqueue: /usr/lib64/python3.14/site-packages/ipcqueue/_posixmq.abi3.so
python3-ipcqueue: /usr/lib64/python3.14/site-packages/ipcqueue/_sysvmq.abi3.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/i/ipcqueue/ipcqueue-0.9.7.tar.gz :
  CHECKSUM(SHA256) this package     : 92d3361afe04a24d89b0b25485f6634c8c51aad465ae7a564cc4b81f7e04cf64
  CHECKSUM(SHA256) upstream package : 92d3361afe04a24d89b0b25485f6634c8c51aad465ae7a564cc4b81f7e04cf64


Requires
--------
python3-ipcqueue (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    python(abi)
    python3.14dist(cffi)
    rtld(GNU_HASH)



Provides
--------
python3-ipcqueue:
    python-ipcqueue
    python3-ipcqueue
    python3-ipcqueue(x86-64)
    python3.14-ipcqueue
    python3.14dist(ipcqueue)
    python3dist(ipcqueue)



Diff spec file in url and in SRPM
---------------------------------
--- /home/fedora-packaging/reviews/python-ipcqueue/2401447-python-ipcqueue/srpm/python-ipcqueue.spec	2025-10-05 06:55:54.277216066 +0300
+++ /home/fedora-packaging/reviews/python-ipcqueue/2401447-python-ipcqueue/srpm-unpacked/python-ipcqueue.spec	2025-10-04 03:00:00.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.1)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 Name:           python-ipcqueue
 Version:        0.9.7
@@ -47,3 +57,6 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Sat Oct 04 2025 Zbigniew Jędrzejewski-Szmek <zbyszek.pl> - 0.9.7-1
+- Initial packaging
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2401447
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python, C/C++
Disabled plugins: Perl, Ocaml, fonts, Java, R, SugarActivity, PHP, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) License file is installed twice
rpm -qL  python3-ipcqueue-0.9.7-1.fc44.x86_64.rpm 
/usr/lib64/python3.14/site-packages/ipcqueue-0.9.7.dist-info/licenses/AUTHORS
/usr/lib64/python3.14/site-packages/ipcqueue-0.9.7.dist-info/licenses/LICENSE
/usr/share/licenses/python3-ipcqueue/LICENSE

Please change
%pyproject_save_files ipcqueue
to
%pyproject_save_files -l ipcqueue

and remove
%license LICENSE

b) Deprecation warnings in build log

        Please consider removing the following classifiers in favor of a SPDX license expression:
        License :: OSI Approved :: BSD License
        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
 
        Please remove any references to `setuptools.command.test` in all supported versions of the affected package.
        This deprecation is overdue, please update your project and remove deprecated
        calls to avoid build errors in the future.

Consider applying the patch:
https://github.com/seifert/ipcqueue/pull/8

c) Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=137787209
d) It would be nice to build documentation

Created attachment 2108572 [details]
spec file that builds documentation

It is possible to add a man page.  Consider doing this, but does not block the review.

Review of one of:
https://bugzilla.redhat.com/show_bug.cgi?id=2399984
https://bugzilla.redhat.com/show_bug.cgi?id=2386164
https://bugzilla.redhat.com/show_bug.cgi?id=2399993
would be appreciated if time allows.

Thanks! I applied suggestions a) and d), but I built both man page and html docs.
The html docs end up in a separate noarch package because they are 420 kB.
I didn't do b) because the file is only used in the build and the patch doesn't
work (yet).

Spec URL: https://in.waw.pl/~zbyszek/fedora/python-ipcqueue.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-ipcqueue-0.9.7-4.fc44.src.rpm

koji build: Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=137793220

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ipcqueue