Bug 240171
| Summary: | Review Request: bigboard - Sidebar application launcher using mugshot.org | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bnocera, mclasen |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | mclasen:
fedora-review+
j: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-05-31 23:43:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Colin Walters
2007-05-15 16:34:15 UTC
Small things: - People want a full source url - Why do you have to set GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL if the package does not contain gconf schemata anyway ? - python packages are supposed to define some python_sitearch thing up top Looking good at first glance. The only thing I see right now is that shouldn't include .la files. I'll go over the checklist later tonight or tomorrow. The package needs to own /usr/lib/bigboard and /usr/share/bigboard COPYING says "see LICENSE", but there is no LICENSE file Why does main.py live under /usr/libexec ? Can't that live under /usr/share, too ? The packaging guidelines have a stupid rule about "every gui app needs a desktop file" - you should just put a comment in the spec stating that bigboard does not need one. Squish squish, squish, (skip), squish. On the libexec thing...it's an artifact of the current build/run system which I am a bit loath to touch again. Basically I had a lot of trouble getting things so they could easily run both installed and uninstalled. New files uploaded: http://download.mugshot.org/extras/bigboard/source/bigboard-0.3.2.tar.gz http://download.mugshot.org/extras/bigboard/source/bigboard.spec I'm fine with things staying in libexec. Going thru the checklist now: - rpmlint is silent - package name is ok - spec file name is ok - packaging guidelines are met - license: GPL, ok - license tag ok - license text included in %doc - spec file written in excellent, legible language - upstream source ok - locale handling n/a - shared libs n/a - not a relocatable package - directory ownership: still missing /usr/share/bigboard/stocks - no duplicate files - file permissions: ok - %clean section: ok - consistent macro use: ok - package content: ok - large documentation: n/a - %doc sanity: ok - headers: n/a - static libs n/a - pkgconfig files: n/a - shared libs: n/a - la files: ok - desktop file: ok - ownership: ok - %install cleans buildroot, ok - filenames: ok still waiting for my mock build to complete... mock build completed successfully, so BRs are ok, too The only remaining issue is the unowned directory. Looks good now. Approved. (In reply to comment #11) > squish! > > http://download.mugshot.org/extras/bigboard/source/bigboard.spec The following directries don't seem to be owned?? (on i386) /usr/lib/python2.5/site-packages/bigboard/httplib2/ /usr/lib/python2.5/site-packages/bigboard/keybinder/ /usr/lib/python2.5/site-packages/bigboard/libbig/ Mamoru - fixed! New Package CVS Request ======================= Package Name: bigboard Short Description: Sidebar application launcher using mugshot.org Owners: walters Branches: FC-6 FC-7 InitialCC: (In reply to comment #14) > Mamoru - fixed! Seems okay. Package Change Request ====================== Package Name: bigboard New Branches: F7 Note: It's "F-7". Also, please don't reopen tickets just to make CVS requests. Branch created. |