Bug 240194
Summary: | Review Request: dgae - DG, a short AGI adventure game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | hdegoede:
fedora-review+
wtogami: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-05-22 23:04:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 239812 | ||
Bug Blocks: |
Description
Gwyn Ciesla
2007-05-15 18:31:57 UTC
MUST: ===== * rpmlint output is: E: dgae zero-length /usr/share/dgae/snddir This is "normal" for this package and can be ignored * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream (as explained in the comment) * Compiles and builds on devel x86_64 * BR: ok * No locales * No shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions * %clean & macro usage OK * Contains code and permissable content * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed * .desktop file as required and properly installed Must FIX ======== * The URL field is invalid, change it to: http://membres.lycos.fr/agisite/agisite.htm * Drop the bogus " dg" argument to %setup * readme.txt is not in UTF-8 , this fixes it: iconv -f IBM850 -t UTF8 readme.txt > readme.txt.tmp mv readme.txt.tmp readme.txt Should fix ========== * Change the last line of dgae-wrapper.sh from 'nagi' to 'exec nagi "$@"' the exec removes a useless bash instance from memory (since the script does nothing after the nagi line, bash can just be replaced with nagi instead of nagi running under bash. the "$@" passed any cmdline args given to the script to nagi (although it seems that nagi takes no cmdline args??). Fixed all the musts and shoulds above. Spec URL: http://zanoni.jcomserv.net/fedora/dgae/dgae.spec SRPM URL: http://zanoni.jcomserv.net/fedora/dgae/dgae-1.1-2.src.rpm I'll apply these to serguei's destiny where applicable. looks good, approved! (atill has to wait for nagi though. Xavier seems to be somewhat slow there, maybe you should ping him asking him to step down if he doesn't have the time, you can tell him you have another reviewer ready to go :) New Package CVS Request ======================= Package Name: dgae Short Description: a short AGI adventure game Owners: limb Branches: FC-5 FC-6 InitialCC: Built in all branches. |