Bug 240243
| Summary: | Review Request: gpsdrive - A GPS based navigation tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
| Component: | Package Review | Assignee: | Jeremy Hinegardner <jeremy> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeff, sberry |
| Target Milestone: | --- | Flags: | jeremy:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-07-03 21:11:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kevin Fenzi
2007-05-16 00:24:21 UTC
I'll be happy to review gpsdrive. Look for the formal review shortly. OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistent macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
eaa52cb220f3d10312a1046dd47126bb gpsdrive-2.09.tar.gz (upstream)
eaa52cb220f3d10312a1046dd47126bb rpmbuild/SOURCES/gpsdrive-2.09.tar.gz
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Doc subpackage needed/used. (not needed)
OK - Packages %doc files don't affect runtime.
OK - Spec has needed ldconfig in post and postun
OK - .la files are removed.
OK - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
ISSUE (1) - rpmlint output.
SHOULD Items:
OK - Should build in mock.
OK - Should function as described. (program launched ok)
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version
SHOULD Items:
OK - Should build in mock.
OK - Should function as described. (program launched ok)
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version
Issues:
1. rpm lint output
E: gpsdrive incorrect-locale-el /usr/share/locale/gr/LC_MESSAGES/gpsdrive.mo
It appears that gpsdrive is shipping the Greek messages using the ISO
country code for Greece ('gr') instead of the ISO 639 locale code for the
greek language ('el'). I would consider this an upstream bug, but if you
want to fix it in the rpm that's fine and then lodge the issue upstream
that would allow the Greek language Fedora users to use gpsdrive.
I don't know much about I18N in C programs, but would moving the gr.po
and gr.pmo files to el.po and el.pmo respectively after the man page
conversion to UTF-8 fix this issue?
Including _that_ "INSTALL" document in %doc is of no use for RPM package users. In reply to comment #2: Thanks for the review. Alas, just moving the po files doesn't seem to fix things. Looks like I am going to have to patch the auto* files to get it to know about 'el' instead of 'gr'. ;( Will try and get that sorted out soon. In reply to comment #3: Yeah, sorry I missed that. Next version will not ship the useless INSTALL file. :( Hopefully I will have a new version soon. ok. Sorry for the vast delay here. Both the above items should be taken care of now in this latest version. Spec URL: http://www.scrye.com/~kevin/fedora/gpsdrive/gpsdrive.spec SRPM URL: http://www.scrye.com/~kevin/fedora/gpsdrive/gpsdrive-2.09-3.fc8.src.rpm diff of spec: 4c4 < Release: 3%{?dist} --- > Release: 2%{?dist} 10d9 < Patch1: gpsdrive-2.09-greek.patch 16d14 < BuildRequires: autoconf m4 33d30 < %patch1 -p1 40,43d36 < # move greek from gr to el < mv po/gr.gmo po/le.gmo < mv po/gr.po po/le.po < 105c98 < %doc GPS-receivers AUTHORS COPYING CREDITS TODO --- > %doc GPS-receivers INSTALL AUTHORS COPYING CREDITS TODO 141,144d133 < * Mon Jun 18 2007 Kevin Fenzi <kevin> - 2.09-3 < - Do not ship useless INSTALL file. < - Fix incorrect greek translation. (In reply to comment #5) > ok. Sorry for the vast delay here. > > Both the above items should be taken care of now in this latest version. > > Spec URL: http://www.scrye.com/~kevin/fedora/gpsdrive/gpsdrive.spec > SRPM URL: http://www.scrye.com/~kevin/fedora/gpsdrive/gpsdrive-2.09-3.fc8.src.rpm > < * Mon Jun 18 2007 Kevin Fenzi <kevin> - 2.09-3 > < - Do not ship useless INSTALL file. > < - Fix incorrect greek translation. > Everything looks good to me. rpmlint is satisfied and the INSTALL file is not shipped. This package is Approved. Excellent. Thanks for the review, and sorry it took so long to finish up the last issues. Package Name: gpsdrive Short Description: A GPS based navigation tool Owners: kevin Branches: F-7 FC-6 InitialCC: cvs done. Sorry, forgot to close this one up. Built for fc6, f7 and devel. |