Bug 240323
Summary: | Review Request: telepathy-salut - Link-local XMPP telepathy connection manager | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> | ||||||
Component: | Package Review | Assignee: | Jason Tibbitts <j> | ||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | high | ||||||||
Version: | rawhide | CC: | bdpepple, pbrobinson, sebastian | ||||||
Target Milestone: | --- | Flags: | sebastian:
fedora-review+
kevin: fedora-cvs+ |
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2007-06-28 20:42:18 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Brian Pepple
2007-05-16 14:42:38 UTC
Created attachment 154828 [details]
Mock build log
telepathy-glib has been added to fedora. Upping the priority of this. Spec URL: http://spotbox.dyn.dhs.org/telepathy-salut.spec SRPM URL: http://spotbox.dyn.dhs.org/telepathy-salut-0.1.3-1.fc7.src.rpm Updated spec for newest version since telepathy-glib is available in Fedora now. Created attachment 157965 [details]
Build log for latest spec file.
Not much to say here. rpmlint just complains about W: telepathy-salut mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13) which is no big deal. Review: * source files match upstream: 14d2db936bcfdb8e441536106bfcce7f2f59e6d0d4f635af22657801345139ab telepathy-salut-0.1.3.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint nas only acceptable complaints. * final provides and requires are sane: telepathy-salut = 0.1.3-1.fc8 = libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libavahi-glib.so.1()(64bit) libcrypto.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libssl.so.6()(64bit) libtelepathy-glib.so.0()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) telepathy-filesystem * %check is not present; no test suite upstream. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. /usr/share/dbus1-service is owned by dbus, a dependency via libdbus /usr/share/telepathy-managers is owned by telepathy-filesystem * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED New Package CVS Request ======================= Package Name:telepathy-salut Short Description: Link-local XMPP telepathy connection manager Owners: bdpepple,johnp Branches: F-7,OLPC-2 InitialCC: cvs done. Tibbs, thanks for the review! ------------------------- Imported & tagged for devel, F-7, and OLPC-2. Built for devel & F7. I'll let J5 handle the build for OLPC. :) Package Change Request ====================== Package Name: telepathy-salut New Branches: EL-6 Owners: pbrobinson sdz Have you checked with Brian here to see if he would like to maintain this in EPEL? Package Change Request ====================== Package Name: telepathy-salut New Branches: EL-6 Owners: pbrobinson sdz bpepple I emailed Brian and he said that it would probably be better if someone else maintained the EPEL branches, since he's not currently running any systems that use EPEL. If you need additional confirmation, can you comment here please, Brian? For background, we're interested in maintaining these in EPEL since they are dependencies of the Sugar Environment, which we're trying to push into EPEL. Argh, I'm being stupid. Setting fedora-cvs instead of fedora-review. Sorry for the noise. CVS done (by process-cvs-requests.py). |