Bug 240391
| Summary: | Review Request: testoob - Advanced unit testing framework for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Devan Goodwin <dgoodwin> |
| Component: | Package Review | Assignee: | Ruben Kerkhof <ruben> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | ruben:
fedora-review+
kevin: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-23 21:45:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Devan Goodwin
2007-05-17 00:41:30 UTC
Hi Devan,
> The script in question has an opening line of #!/usr/bin/env python
> but is not executable in the upstream source.
> If this is a problem I can submit a patch to the maintainer.
Please report this upstream.
You can fix it in the %prep section with a simple chmod until upstream fixes this.
Review for release 1:
* RPM name is OK
* Source testoob-1.13.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK
Attempted to chmod with:
%prep
%setup -q -n testoob-%{version}
chmod u+x src/testoob/compatibility/trace.py
But this does not seem to work, any ideas what I might be doing wrong? The chmod
executes and finds the file, but the resulting rpm still lacks the execute
permission.
Also, I'm not entirely sure how important this script is but considering it's
final destination (/usr/lib/python2.5/site-packages/testoob/) should it be made
executable (or included) at all?
Seems like distutils resets permissions. I added
chmod 0755 $RPM_BUILD_ROOT%{python_sitelib}/testoob/compatibility/trace.py
add the end of the %install section, and that worked.
It looks like the trace module is used by coverage.py, so I would leave it in site-packages.
Spec URL: http://dangerouslyinc.com/rpm/testoob/testoob.spec SRPM URL: http://dangerouslyinc.com/rpm/testoob/testoob-1.13-2.fc7.src.rpm Made the suggested change to the install section, rpmlint is now happy as well. Problem has also been reported upstream. Can you include the upstream tarbal in your srpm? [ruben@odin review]$ sha1sum testoob-1.13.tar.gz.upstream testoob-1.13.tar.gz 670496cef42897dabc1514c5f79869c98074d4d8 testoob-1.13.tar.gz.upstream afcd89f142d3d5de0211cae75f8a655d94f9ca1b testoob-1.13.tar.gz Oops, I seem to have re-tarred myself with the script change discussed above and forgotten about it. Fixed now. Spec URL: http://dangerouslyinc.com/rpm/testoob/testoob.spec SRPM URL: http://dangerouslyinc.com/rpm/testoob/testoob-1.13-3.fc7.src.rpm Review for release 3: * RPM name is OK * Source testoob-1.13.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK * I did some basic functionality testing, it works OK This package is approved. New Package CVS Request ======================= Package Name: testoob Short Description: Advanced unit testing framework for Python. Owners: dgoodwin Branches: F-7 InitialCC: cvs done. Devan, can you close this one when you're done? My apologies, missed a step. Closing now. |