Bug 2404348 (rust-cms)

https://github.com/RustCrypto/formats/pull/2069 [fix missing license files upstream]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9696628
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404348-rust-cms/fedora-rawhide-x86_64/09696628-rust-cms/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to Gerd Hoffmann from comment #1)
> https://github.com/RustCrypto/formats/pull/2069 [fix missing license files
> upstream]

Merged.

Hmm, rust2rpm checks for the license /before/ applying the patches, so adding https://github.com/RustCrypto/formats/commit/f76fafc9415b27f9756cfb7c4b7d43c9907b1380 via extra-patches in rust2rpm.toml does not work.

(In reply to Gerd Hoffmann from comment #4)
> Hmm, rust2rpm checks for the license /before/ applying the patches, so
> adding
> https://github.com/RustCrypto/formats/commit/
> f76fafc9415b27f9756cfb7c4b7d43c9907b1380 via extra-patches in rust2rpm.toml
> does not work.

What you *can* do is add the license file from upstream as an extra source, like this:

https://src.fedoraproject.org/rpms/rust-fax/blob/c29503f7445d80da0c868ca48af81e69408afc3c/f/rust2rpm.toml

spec url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09709349-rust-cms/rust-cms.spec
srpm url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09709349-rust-cms/rust-cms-0.2.3-1.fc44.src.rpm

Created attachment 2110342 [details]
The .spec file difference from Copr build 9696628 to 9709488

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9709488
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404348-rust-cms/fedora-rawhide-x86_64/09709488-rust-cms/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks like this now fails to build after the update to hex-literal v1 in Fedora.

You might need to apply a patch to bump the dependency from v0.4 to v1.

spec url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09991468-rust-cms/rust-cms.spec
srpm url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09991468-rust-cms/rust-cms-0.2.3-1.fc44.src.rpm

Created attachment 2121649 [details]
The .spec file difference from Copr build 9709488 to 9991834

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9991834
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2404348-rust-cms/fedora-rawhide-x86_64/09991834-rust-cms/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package was generated with rust2rpm, simplifying the review.

Two minor issues that you can address before importing the package:

1. Exclude the test input data from the built packages (%exclude'ing "tests/examples" should be enough).
   The files under tests/examples/* are bigger than the rest of the crate sources combined. :)
2. Please regenerate the spec file, it should use rpmautospec (%autorelease / %autochangelog).

===

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license files are included with %license in %files
   Included manually from upstream,
   PR to include them in the next published version was submitted and already merged.
✅ package complies with Rust Packaging Guidelines
   -- with caveat about using rpmautospec.

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cms

FEDORA-2026-facd08d2c7 (rust-cms-0.2.3-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-facd08d2c7

> - set up package on release-monitoring.org:
>   project: $crate

Hmm, there is a name clash:
https://release-monitoring.org/project/377971/

Suggestions how to handle this?
Would be using 'rust-cms' as project name ok?

FEDORA-2026-facd08d2c7 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-facd08d2c7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-facd08d2c7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-facd08d2c7 (rust-cms-0.2.3-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

(In reply to Gerd Hoffmann from comment #16)
> > - set up package on release-monitoring.org:
> >   project: $crate
> 
> Hmm, there is a name clash:
> https://release-monitoring.org/project/377971/
> 
> Suggestions how to handle this?
> Would be using 'rust-cms' as project name ok?

There are no clashes on the project "name" on release-monitoring.org, so you can use "cms".