Bug 240642 (pidgin-libnotify)
Summary: | Review Request: pidgin-libnotify - Libnotify Pidgin plugin | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Gordon <peter> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mtasaka |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
wtogami: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-05-22 01:27:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 237264 |
Description
Peter Gordon
2007-05-19 05:59:57 UTC
? While you renamed the package name to pidgin-libnotify, why did you leave the name of the module as gaim-libnotify.so and gettext .mo files as gaim-libnotify?? * Why do you have this package provide "gaim-libnotify = 0.12-6", not gaim-libnotify = %{version}-%{release}" ? * And also check documentation. At least the contents of README should be fixed. (In reply to comment #1) > ? While you renamed the package name to pidgin-libnotify, > why did you leave the name of the module as gaim-libnotify.so > and gettext .mo files as gaim-libnotify?? The current patch merely fixes it to build against the new API of Pidgin/Libpurple. The output shared library and gettext modules are not renamed because it did not seem necessary to do so to provide the functionality of the plugin (and would increase the amount of downstream patching for an insignificant benefit). > * Why do you have this package provide "gaim-libnotify = 0.12-6", > not gaim-libnotify = %{version}-%{release}" ? Hmm. I don't remember why I hardcoded those. :) Fixed in 0.12-7, and the files are on my webspace: Spec: http://thecodergeek.com/downloads/fedora/SPECs/pidgin-libnotify.spec SRPM: http://thecodergeek.com/downloads/fedora/SRPMs/pidgin-libnotify-0.12-7.fc7.src.rpm (In reply to comment #2) > * And also check documentation. At least the contents > of README should be fixed. I didn't include the README because it contains nothing relevant to this package, just a brief description (which the RPM information already contains) and some generic build instructions (which are unnecessary for end-users): "gaim-libnotify About ===== Gaim-libnotify provides a libnotify interface to Gaim INSTALL ======= ./configure --with-gaim=PATH/TO/GAIM make make install" (In reply to comment #3) > (In reply to comment #1) > > ? While you renamed the package name to pidgin-libnotify, > > why did you leave the name of the module as gaim-libnotify.so > > and gettext .mo files as gaim-libnotify?? > > The current patch merely fixes it to build against the new API of > Pidgin/Libpurple. Okay. > > * Why do you have this package provide "gaim-libnotify = 0.12-6", > > not gaim-libnotify = %{version}-%{release}" ? > > Fixed in 0.12-7, and the files Confirmed. > (In reply to comment #2) > > * And also check documentation. At least the contents > > of README should be fixed. > > I didn't include the README Actually... Okay. -------------------------------------------- This package (pidgin-libnotify) is APPROVED by me -------------------------------------------- Yay; thanks, Mamoru Tasaka! New Package CVS Request ======================= Package Name: pidgin-libnotify Short Description: Libnotify Pidgin plugin Owners: peter Branches: F-7 devel |