Bug 2406908
| Summary: | Review Request: gmm - A generic C++ template library for sparse, dense and skyline matrices | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Antonio T. sagitter <trpost> |
| Component: | Package Review | Assignee: | Sandro Mani <manisandro> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | manisandro, package-review, trpost |
| Target Milestone: | --- | Flags: | manisandro:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://getfem.org/gmm.html | ||
| Whiteboard: | Unretirement | ||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-11-12 00:47:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Antonio T. sagitter
2025-10-28 20:07:19 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9740935 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2406908-gmm/fedora-rawhide-x86_64/09740935-gmm/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/gmm Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Only issue I see is that the code appears to be licensed as "LGPL-3.0-or-later AND BSD 3-Clause", but the spec license specifies "LGPL-2.0-or-later". Please adjust the License tag before importing.
Approved
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Header files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU Lesser General
Public License v3.0 or later", "FSF All Permissive License", "GNU Free
Documentation License v1.3 or later and/or GNU Lesser General Public
License v3.0 or later", "FSF Unlimited License (with License
Retention) [generated file]", "GNU General Public License v2.0 or
later [generated file]", "GNU General Public License v3.0 or later",
"FSF Unlimited License [generated file]", "GNU Lesser General Public
License v3.0 or later", "X11 License [generated file]", "GNU General
Public License v2.0 or later", "FSF Unlimited License (with License
Retention) and/or GNU General Public License, Version 2", "FSF
Unlimited License (with License Retention)", "BSD 3-Clause License
and/or GNU Lesser General Public License v3.0 or later". 12 files have
unknown license. Detailed output of licensecheck in
2406908-gmm/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 1450 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: gmm-devel-5.4.4-1.fc44.noarch.rpm
gmm-5.4.4-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpb3cuen5o')]
checks: 32, packages: 2
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_MUMPS_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_algobase.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_blas.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_blas_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_condition_number.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_conjugated.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_def.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_Householder.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_lu.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_matrix_functions.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_qr.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_sylvester.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_domain_decomp.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_except.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_feedback_management.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_inoutput.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_interface_bgeot.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_iter.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_iter_solvers.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_kernel.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_lapack_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_least_squares_cg.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_matrix.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_modified_gram_schmidt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_opt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_diagonal.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ildlt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ildltt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ilu.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ilut.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ilutp.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_mr_approx_inverse.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_range_basis.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_real_part.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_ref.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_scaled.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_Schwarz_additive.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_bfgs.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_bicgstab.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_cg.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_constrained_cg.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_gmres.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_idgmres.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_qmr.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_std.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_sub_index.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_sub_matrix.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_sub_vector.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_superlu_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_transposed.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_tri_solve.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_vector.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_vector_to_matrix.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/share/doc/gmm-devel/README
gmm-devel.noarch: E: incorrect-fsf-address /usr/share/licenses/gmm-devel/COPYING
2 packages and 0 specfiles checked; 58 errors, 0 warnings, 7 filtered, 58 badness; has taken 0.6 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_MUMPS_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_algobase.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_blas.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_blas_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_condition_number.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_conjugated.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_def.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_Householder.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_lu.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_matrix_functions.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_qr.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_dense_sylvester.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_domain_decomp.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_except.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_feedback_management.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_inoutput.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_interface_bgeot.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_iter.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_iter_solvers.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_kernel.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_lapack_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_least_squares_cg.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_matrix.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_modified_gram_schmidt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_opt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_diagonal.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ildlt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ildltt.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ilu.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ilut.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_ilutp.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_precond_mr_approx_inverse.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_range_basis.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_real_part.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_ref.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_scaled.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_Schwarz_additive.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_bfgs.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_bicgstab.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_cg.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_constrained_cg.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_gmres.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_idgmres.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_solver_qmr.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_std.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_sub_index.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_sub_matrix.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_sub_vector.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_superlu_interface.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_transposed.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_tri_solve.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_vector.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/include/gmm/gmm_vector_to_matrix.h
gmm-devel.noarch: E: incorrect-fsf-address /usr/share/doc/gmm-devel/README
gmm-devel.noarch: E: incorrect-fsf-address /usr/share/licenses/gmm-devel/COPYING
1 packages and 0 specfiles checked; 58 errors, 0 warnings, 3 filtered, 58 badness; has taken 0.2 s
Source checksums
----------------
https://download-mirror.savannah.gnu.org/releases/getfem/stable/gmm-5.4.4.tar.gz :
CHECKSUM(SHA256) this package : 15eb1943011b92665aab3b02ecf3cede1cf89ea15a9006f81f2ba2cd662aa02b
CHECKSUM(SHA256) upstream package : 15eb1943011b92665aab3b02ecf3cede1cf89ea15a9006f81f2ba2cd662aa02b
Requires
--------
gmm-devel (rpmlib, GLIBC filtered):
Provides
--------
gmm-devel:
gmm
gmm++-devel
gmm-devel
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2406908
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: PHP, Ocaml, C/C++, Haskell, R, fonts, Perl, SugarActivity, Java, Python
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Fixed, thank you Spec URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/09752350-gmm/gmm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/09752350-gmm/gmm-5.4.4-1.fc44.src.rpm The Pagure repository was created at https://src.fedoraproject.org/rpms/gmm The Pagure repository was created at https://src.fedoraproject.org/rpms/gmm FEDORA-2025-48a11cf93f (gmm-5.4.4-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-48a11cf93f FEDORA-2025-48a11cf93f has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-48a11cf93f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-48a11cf93f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-48a11cf93f (gmm-5.4.4-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |