Bug 240699 (perl-MogileFS-Client)

I'm thinking this isn't quite right.

[cweyl@zeus MogileFS-Client-1.07]$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00use........ok                                                            
t/10-basics....skipped
        all skipped: No mogilefsd process running on 127.0.0.1:7001
All tests successful, 1 test skipped.
Files=2, Tests=2,  0 wallclock secs ( 0.25 cusr +  0.06 csys =  0.31 CPU)

Scratch that, I was thinking MogileFS::Admin->new() was kicking off a daemon. *sigh*

I was thinking that myself, but it's trying to connect to a mogilefs server on localhost.

Hey, a three-way review swap.  Fun!

Just some minor issues:

I wonder if a more correct URL wouldn't be
  http://search.cpan.org/~bradfitz/MogileFS-Client/
I don't think it's particularly important, but it takes some clicking to get
down to the Perl module from the master mogilefs site..

Since the 10-basics.t test simply can't do anything useful without an actual
server running locally, I suggest that you just delete the test file before
running make test:
  %check
  # This test cannot run without a local MogileFS server
  rm t/10-basics.t
  make test

I don't think either of these issues are significant enough to hold up this package.

Review:
* source files match upstream:
   1ab698d91c2548458d0e5b84cd2b1fcbb7e44fac907a738b2933b38233238be8
   MogileFS-Client-1.07.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(MogileFS::Admin)
   perl(MogileFS::Backend)
   perl(MogileFS::Client) = 1.07
   perl(MogileFS::NewHTTPFile)
   perl-MogileFS-Client = 1.07-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Errno)
   perl(IO::Socket::INET)
   perl(IO::WrapTie)
   perl(LWP::UserAgent)
   perl(MogileFS::Backend)
   perl(MogileFS::Client)
   perl(MogileFS::NewHTTPFile)
   perl(POSIX)
   perl(Socket)
   perl(Time::HiRes)
   perl(fields)
   perl(strict)
   perl(vars)
* %check is present and all tests which can be run pass:
   All tests successful, 1 test skipped.
   Files=2, Tests=2,  1 wallclock secs ( 0.34 cusr +  0.08 csys =  0.42 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Thanks for the review and good suggestions, I'll change them in the spec.

New Package CVS Request
=======================
Package Name: perl-MogileFS-client
Short Description: Client library for the MogileFS distributed file system
Owners: ruben
Branches: FC-6 F-7 EPEL-4 EPEL-5

cvs done. 
Note that the EPEL branches are "EL-4" and "EL-5" for the cvs template. 

Thanks Kevin,

Sorry, I made a typo, the package is called perl-MogileFS-Client, not perl-MogileFS-client

New Package CVS Request
=======================
Package Name: perl-MogileFS-Client
Short Description: Client library for the MogileFS distributed file system
Owners: ruben
Branches: FC-6 F-7 EL-4 EL-5

ok. I think I have this fixed. Can you look now and see?

No luck:

[ruben@odin common]$ ./cvs-import.sh ~/rpmbuild/SRPMS/perl-MogileFS-Client-1.07-2.fc7.src.rpm 
Checking out module: 'perl-MogileFS-Client'
Unpacking source package: perl-MogileFS-Client-1.07-2.fc7.src.rpm...
L MogileFS-Client-1.07.tar.gz
A perl-MogileFS-Client.spec

Checking : MogileFS-Client-1.07.tar.gz on https://cvs.fedora.redhat.com/repo/pkgs/upload.cgi...
Module 'perl-MogileFS-client' does not exist!
make: *** [upload] Error 1
ERROR: Uploading the source tarballs failed!

Sorry about that. Forgot to clean up the owners list as well. 
Can you try again now? 

Also, note that the wrong name might be in your Makefile, you should be able to
change that with the initial checkin. 

Ah, thanks Kevin, it's working now.

Sorry for the trouble.

Package Change Request
======================
Package Name: perl-MogileFS-Client
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

This is now done via pkgdb.