Bug 2407352
| Summary: | Review Request: headset-battery-indicator - System tray application for controlling USB headsets (HeadsetControl GUI) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Juan Jose Vazquez Prieto <juan75555> | ||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/ruflas/headset-battery-indicator | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | --- | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 177841 | ||||||||
| Attachments: |
|
||||||||
|
Description
Juan Jose Vazquez Prieto
2025-10-30 10:42:51 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. * **SPEC URL:** https://copr-dist-git.fedorainfracloud.org/packages/ruflas/headset-battery-indicator/headset-battery-indicator.git/plain/python-headset-battery-indicator.spec * **SRPM URL:** https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/fedora-43-x86_64/09747960-headset-battery-indicator/headset-battery-indicator-1.3.0-1.fc43.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/9749333 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407352-headset-battery-indicator/fedora-rawhide-x86_64/09749333-headset-battery-indicator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated package to v2.2.0 with the following fixes based on Fedora packaging guidelines: Migrated to modern pyproject RPM macros (%pyproject_wheel, %pyproject_install, %generate_buildrequires) Fixed Requires: python3-pyside6 (correct Fedora package name) Added .desktop file to source repository with proper fields Used desktop-file-install for .desktop validation Successful Copr build on Fedora 42, 43, 44 and rawhide: https://copr.fedorainfracloud.org/coprs/ruflas/headset-battery-indicator/build/10424162/ SPEC URL: https://raw.githubusercontent.com/ruflas/headset-battery-indicator/main/python-headset-battery-indicator.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/srpm-builds/10424162/python-headset-battery-indicator-2.2.0-1.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/10424171 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407352-headset-battery-indicator/fedora-rawhide-x86_64/10424171-python-headset-battery-indicator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated package to v2.2.0 with the following additional fixes:
Renamed spec from python-headset-battery-indicator.spec to headset-battery-indicator.spec — the python- prefix is reserved for Python libraries per Fedora guidelines, not applications
Changed Name: field accordingly to headset-battery-indicator
Added Obsoletes: python-headset-battery-indicator < 2.3.0 and Provides: python-headset-battery-indicator = %{version} for a clean upgrade path
Successful Copr build on Fedora 42, 43, 44 and rawhide:
https://copr.fedorainfracloud.org/coprs/ruflas/headset-battery-indicator/build/10445409/
SPEC URL: https://raw.githubusercontent.com/ruflas/headset-battery-indicator/main/headset-battery-indicator.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/srpm-builds/10445409/headset-battery-indicator-2.2.0-1.src.rpm
> Provides: python-headset-battery-indicator = %{version} This should include the Release number, as well. https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages > %post > update-desktop-database &> /dev/null || : > touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || : > > %postun > update-desktop-database &> /dev/null || : > gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || : These are not needed since at least Fedora 30. (In reply to Artur Frenszek-Iwicki from comment #7) > > Provides: python-headset-battery-indicator = %{version} > This should include the Release number, as well. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or- > replacing-existing-packages > > > %post > > update-desktop-database &> /dev/null || : > > touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || : > > > > %postun > > update-desktop-database &> /dev/null || : > > gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || : > These are not needed since at least Fedora 30. Fixed both issues raised in the previous review: 1. `Provides` now includes the Release number: `Provides: python-headset-battery-indicator = %{version}-%{release}` 2. Removed the `%post` and `%postun` scriptlets (`update-desktop-database`, `gtk-update-icon-cache`) along with their associated `Requires(post)` and `Requires(postun)` entries — no longer needed since Fedora 30. Successful Copr build on Fedora 42, 43, 44 and rawhide: https://copr.fedorainfracloud.org/coprs/ruflas/headset-battery-indicator/build/10775090/ SPEC URL: https://raw.githubusercontent.com/ruflas/headset-battery-indicator/main/headset-battery-indicator.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/srpm-builds/10775090/headset-battery-indicator-2.3.1-1.src.rpm [fedora-review-service-build] SPEC URL: https://raw.githubusercontent.com/ruflas/headset-battery-indicator/main/headset-battery-indicator.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/srpm-builds/10775090/headset-battery-indicator-2.3.1-1.src.rpm Created attachment 2152757 [details]
The .spec file difference from Copr build 10424171 to 10776047
Copr build: https://copr.fedorainfracloud.org/coprs/build/10776047 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407352-headset-battery-indicator/fedora-rawhide-x86_64/10776047-headset-battery-indicator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/10776271 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407352-headset-battery-indicator/fedora-rawhide-x86_64/10776271-headset-battery-indicator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > install -Dm0644 headset-battery-indicator.png \ > %{buildroot}%{_datadir}/icons/hicolor/512x512/apps/headset-battery-indicator.png Add -p here to preserve the file timestamp. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps > %files > %{_datadir}/icons/hicolor/512x512/apps/headset-battery-indicator.png This necessitates "Requires: hicolor-icon-theme". (In reply to Artur Frenszek-Iwicki from comment #13) > > install -Dm0644 headset-battery-indicator.png \ > > %{buildroot}%{_datadir}/icons/hicolor/512x512/apps/headset-battery-indicator.png > Add -p here to preserve the file timestamp. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps > > > %files > > %{_datadir}/icons/hicolor/512x512/apps/headset-battery-indicator.png > This necessitates "Requires: hicolor-icon-theme". Fixed both issues from comment #13: Added -p to install -Dpm0644 to preserve the file timestamp, per Fedora packaging guidelines. Added Requires: hicolor-icon-theme since the package installs a file into the hicolor icon directory. Bumped to 2.3.1-2. SPEC URL: https://raw.githubusercontent.com/ruflas/headset-battery-indicator/main/headset-battery-indicator.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/srpm-builds/10802458/headset-battery-indicator-2.3.1-2.src.rpm Created attachment 2153214 [details]
The .spec file difference from Copr build 10776271 to 10802463
Copr build: https://copr.fedorainfracloud.org/coprs/build/10802463 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407352-headset-battery-indicator/fedora-rawhide-x86_64/10802463-headset-battery-indicator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |