Bug 2407461
| Summary: | Review Request: python-azure-mgmt-resource-deployments - Microsoft Azure Resource Deployments Management Client Library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeremy Cline <jeremy> | ||||
| Component: | Package Review | Assignee: | Ben Beasley <code> | ||||
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | code, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | code:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://pypi.org/project/%{srcname}/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Jeremy Cline
2025-10-30 18:27:59 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9750046 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407461-python-azure-mgmt-resource-deployments/fedora-rawhide-x86_64/09750046-python-azure-mgmt-resource-deployments/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 2111489 [details]
The .spec file difference from Copr build 9750046 to 9750060
Copr build: https://copr.fedorainfracloud.org/coprs/build/9750060 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2407461-python-azure-mgmt-resource-deployments/fedora-rawhide-x86_64/09750060-python-azure-mgmt-resource-deployments/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The package is APPROVED, but with some suggestions I hope you will consider.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== Issues =====
- I strongly recommend changing
%pyproject_save_files azure
to
%pyproject_save_files -l azure
in order to assert that a license file is detected and handled in the
.dist-info directory. The package can be approved as-is because it does
contain the correct license file, but this change would guard against
accidental loss of the license file in a future update.
- It looks like the tests can only be run online and/or with real Azure
credentials. If this is the case, it would be helpful to add a comment
to the %check section explaining why the tests can’t be run.
===== Notes (no change required for approval) =====
- I tend to think that "*name" spec-file macros like %srcname and %tarball_name
just add unnecessary indirection and make the spec file harder to read,
without meaningfully improving spec-file “reusability.” This is a matter of
opinion, though, and these macros are entirely permissible.
- You might consider producing %pypi_version automatically from the Version
tag, something like:
%global pypi_version %(echo '%{version}' | tr -d '~')
There’s probably some way to use Lua rather than a subshell to do this.
- There is no longer any need to number Sources, unless you are going to
specifically reference them by number. You can just write:
Source: %{pypi_source %{tarball_name} %{pypi_version}}
- Packaging a beta is OK because there has never been a final release of this
library, and because I know that the Azure stack is sensitive about precise
dependency versions.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "MIT License", "*No copyright* MIT
License". 14 files have unknown license. Detailed output of
licensecheck in /home/ben/fedora/review/2407461-python-azure-mgmt-
resource-deployments/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.14,
/usr/lib/python3.14/site-packages
Spurious diagnostic: python3-libs owns these
[-]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.14/site-
packages/azure(python3-azure-mgmt-cognitiveservices, python3-azure-
datalake-store, python3-azure-mgmt-loganalytics, python3-azure-core,
python3-azure-mgmt-iothubprovisioningservices, python3-azure-common,
python3-azure-mgmt-quota, python3-azure-mgmt-iothub, python3-azure-
mgmt-eventhub, python3-azure-data-tables, python3-azure-mgmt-advisor,
python3-azure-mgmt-core, python3-azure-mgmt-billing, python3-azure-
mgmt-rdbms, python3-azure-mgmt-managedservices, python3-azure-mgmt-
appconfiguration, python3-azure-keyvault-keys, python3-azure-mgmt-
postgresqlflexibleservers, python3-azure-mgmt-sqlvirtualmachine,
python3-azure-synapse-managedprivateendpoints, python3-azure-mgmt-
maps, python3-azure-mgmt-authorization, python3-azure-synapse-spark,
python3-azure-mgmt-applicationinsights, azure-cli, python3-azure-mgmt-
marketplaceordering, python3-azure-identity, python3-azure-mgmt-
datamigration, python3-azure-mgmt-managementgroups, python3-azure-
mgmt-servicefabricmanagedclusters, python3-azure-mgmt-cdn,
python3-azure-mgmt-containerregistry, python3-azure-mgmt-batchai,
python3-azure-graphrbac, python3-azure-mgmt-servicebus, python3-azure-
synapse-artifacts, python3-azure-batch, python3-azure-multiapi-
storage, python3-azure-mgmt-hdinsight, python3-azure-mgmt-
trafficmanager, python3-azure-mgmt-redhatopenshift, python3-azure-ai-
textanalytics, python3-azure-mgmt-search, python3-azure-mgmt-network,
python3-azure-keyvault-administration, python3-azure-mgmt-signalr,
python3-azure-synapse-accesscontrol, python3-azure-mgmt-
extendedlocation, python3-azure-servicebus, python3-azure-mgmt-kusto,
python3-azure-keyvault-certificates, python3-azure-mgmt-media,
python3-azure-mgmt-resource, python3-azure-keyvault-securitydomain,
python3-azure-mgmt-netapp, python3-azure-mgmt-eventgrid,
python3-azure-mgmt-servicelinker, python3-azure-mgmt-devtestlabs,
python3-azure-ai-formrecognizer, python3-azure-mgmt-keyvault,
python3-azure-mgmt-botservice, python3-azure-mgmt-batch,
python3-azure-mgmt-imagebuilder, python3-azure-mgmt-servicefabric,
python3-azure-mgmt-web, python3-azure-storage-common, python3-azure-
mgmt-cosmosdb, python3-azure-mgmt-redis, python3-azure-mgmt-monitor,
python3-azure-mgmt-policyinsights, python3-azure-mgmt-
mysqlflexibleservers, python3-azure-mgmt-apimanagement, python3-azure-
storage-blob, python3-azure-cosmos, python3-azure-monitor-query,
python3-azure-mgmt-subscription, python3-azure-mgmt-containerservice,
python3-azure-mgmt-databoxedge, python3-azure-mgmt-privatedns,
python3-azure-mgmt-containerinstance, python3-azure-appconfiguration,
python3-azure-mgmt-recoveryservices, python3-azure-mgmt-iotcentral,
python3-azure-mgmt-recoveryservicesbackup, python3-azure-keyvault-
secrets, python3-azure-mgmt-sql, python3-azure-mgmt-storage,
python3-azure-mgmt-security, python3-azure-mgmt-compute,
python3-azure-mgmt-support, python3-azure-mgmt-dns, python3-azure-
mgmt-msi, python3-azure-mgmt-appcontainers, python3-azure-mgmt-
synapse), /usr/lib/python3.14/site-packages/azure/mgmt(python3-azure-
mgmt-redis, python3-azure-mgmt-core, python3-azure-mgmt-monitor,
python3-azure-mgmt-billing, python3-azure-mgmt-cognitiveservices,
python3-azure-mgmt-hdinsight, python3-azure-mgmt-policyinsights,
python3-azure-mgmt-trafficmanager, python3-azure-mgmt-rdbms,
python3-azure-mgmt-mysqlflexibleservers, python3-azure-mgmt-
redhatopenshift, python3-azure-mgmt-search, python3-azure-mgmt-
network, python3-azure-mgmt-apimanagement, python3-azure-mgmt-
managedservices, python3-azure-mgmt-signalr, python3-azure-mgmt-
appconfiguration, python3-azure-mgmt-loganalytics, python3-azure-mgmt-
extendedlocation, python3-azure-mgmt-iothubprovisioningservices,
python3-azure-mgmt-containerservice, python3-azure-mgmt-kusto,
python3-azure-mgmt-postgresqlflexibleservers, python3-azure-mgmt-
databoxedge, python3-azure-mgmt-subscription, python3-azure-mgmt-
sqlvirtualmachine, python3-azure-mgmt-media, python3-azure-mgmt-
privatedns, python3-azure-mgmt-quota, python3-azure-mgmt-resource,
python3-azure-mgmt-containerinstance, python3-azure-mgmt-maps,
python3-azure-mgmt-netapp, python3-azure-mgmt-eventgrid,
python3-azure-mgmt-servicelinker, python3-azure-mgmt-authorization,
python3-azure-mgmt-devtestlabs, python3-azure-mgmt-
applicationinsights, python3-azure-mgmt-recoveryservices,
python3-azure-mgmt-iotcentral, python3-azure-mgmt-keyvault,
python3-azure-mgmt-recoveryservicesbackup, python3-azure-mgmt-
marketplaceordering, python3-azure-mgmt-sql, python3-azure-mgmt-
iothub, python3-azure-mgmt-storage, python3-azure-mgmt-botservice,
python3-azure-mgmt-batch, python3-azure-mgmt-imagebuilder,
python3-azure-mgmt-datamigration, python3-azure-mgmt-eventhub,
python3-azure-mgmt-security, python3-azure-mgmt-managementgroups,
python3-azure-mgmt-servicefabricmanagedclusters, python3-azure-mgmt-
compute, python3-azure-mgmt-servicefabric, python3-azure-mgmt-cdn,
python3-azure-mgmt-dns, python3-azure-mgmt-support, python3-azure-
mgmt-msi, python3-azure-mgmt-containerregistry, python3-azure-mgmt-
advisor, python3-azure-mgmt-web, python3-azure-mgmt-batchai,
python3-azure-mgmt-cosmosdb, python3-azure-mgmt-servicebus,
python3-azure-mgmt-synapse, python3-azure-mgmt-appcontainers),
/usr/lib/python3.14/site-packages/azure/mgmt/resource(python3-azure-
mgmt-resource)
These are all namespace packages, which is an appropriate use case for
directory co-ownership.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
$ rpm -qL -p results/python3-azure-mgmt-resource-deployments-1.0.0~b1-1.fc44.noarch.rpm
/usr/lib/python3.14/site-packages/azure_mgmt_resource_deployments-1.0.0b1.dist-info/licenses/LICENSE
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 2063 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://files.pythonhosted.org/packages/source/a/azure_mgmt_resource_deployments/azure_mgmt_resource_deployments-1.0.0b1.tar.gz
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/SourceURL/
OK: this worked when I tried it manually.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
Ignore this; fedora-review is just confused.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
https://koji.fedoraproject.org/koji/taskinfo?taskID=138653045
[-]: %check is present and all tests pass.
It would be good to add a comment explaining why the tests can’t be run.
The package correctly contains an import-only “smoke test” instead, and
that succeeds.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: python3-azure-mgmt-resource-deployments-1.0.0~b1-1.fc44.noarch.rpm
python-azure-mgmt-resource-deployments-1.0.0~b1-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmphar6uf5q')]
checks: 32, packages: 2
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/__init__.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/__init__.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py
2 packages and 0 specfiles checked; 0 errors, 11 warnings, 7 filtered, 0 badness; has taken 0.4 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/__init__.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/__init__.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/aio/operations/_patch.py
python3-azure-mgmt-resource-deployments.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/operations/_patch.py /usr/lib/python3.14/site-packages/azure/mgmt/resource/deployments/models/_patch.py
1 packages and 0 specfiles checked; 0 errors, 11 warnings, 3 filtered, 0 badness; has taken 0.0 s
Requires
--------
python3-azure-mgmt-resource-deployments (rpmlib, GLIBC filtered):
python(abi)
python3.14dist(azure-common)
python3.14dist(azure-mgmt-core)
python3.14dist(isodate)
python3.14dist(typing-extensions)
Provides
--------
python3-azure-mgmt-resource-deployments:
python-azure-mgmt-resource-deployments
python3-azure-mgmt-resource-deployments
python3.14-azure-mgmt-resource-deployments
python3.14dist(azure-mgmt-resource-deployments)
python3dist(azure-mgmt-resource-deployments)
Diff spec file in url and in SRPM
---------------------------------
--- /home/ben/fedora/review/2407461-python-azure-mgmt-resource-deployments/srpm/python-azure-mgmt-resource-deployments.spec 2025-11-01 22:09:03.010869350 +0000
+++ /home/ben/fedora/review/2407461-python-azure-mgmt-resource-deployments/srpm-unpacked/python-azure-mgmt-resource-deployments.spec 2025-10-30 00:00:00.000000000 +0000
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.1)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+ release_number = 1;
+ base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+ print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
%global srcname azure-mgmt-resource-deployments
%global tarball_name azure_mgmt_resource_deployments
@@ -53,3 +63,6 @@
%changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Thu Oct 30 2025 John Doe <packager> - 1.0.0~b1-1
+- Uncommitted changes
+## END: Generated by rpmautospec
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2407461
Buildroot used: fedora-rawhide-aarch64
Active plugins: Python, Shell-api, Generic
Disabled plugins: Ocaml, PHP, C/C++, Haskell, Java, fonts, Perl, R, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Hi Ben, This specfile was shamelessly copied from one the other Azure packages I inherited, so I'll apply all these great suggestions to it (and as many of the others as I can face today). Thanks for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/python-azure-mgmt-resource-deployments |