Bug 241078
Summary: | Review Request: perl-Net-SSH2 - Support for the SSH 2 protocol via libSSH2 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, ppisar, psabata |
Target Milestone: | --- | Flags: | j:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Net-SSH2/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-12-02 21:30:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 398881 | ||
Bug Blocks: |
Description
Chris Weyl
2007-05-23 22:17:55 UTC
As said in bug 239279, I will close this bug if no response from the reporter is received within ONE WEEK. (In reply to comment #1) > As said in libssh2, I will close this bug if no response > from the reporter is received within ONE WEEK. Sorry, I made a confusion... Updated for libssh 0.17, though the review this package depends on seems to be dead. Sigh. http://fedora.biggerontheinside.net/review/perl-Net-SSH2-0.10-2.fc7.src.rpm http://fedora.biggerontheinside.net/review/perl-Net-SSH2.spec I think I should move away from this review. As other review on which this review depends got closed as NOTABUG. Updated to 0.18; resurrected libssh2 review. http://fedora.biggerontheinside.net/review/perl-Net-SSH2-0.18-1.fc6.src.rpm http://fedora.biggerontheinside.net/review/perl-Net-SSH2.spec libssh2 now in Fedora :) Not much to say; now builds fine in rawhide because libssh2 is there, and rpmlint is silent. * source files match upstream: 4bd78eb0b3099271e2047d4e727c8105c07d22d732ca0fb76c37b11f80b64fc4 Net-SSH2-0.18.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: SSH2.so()(64bit) perl(Net::SSH2) = 0.18 perl(Net::SSH2::Channel) perl(Net::SSH2::Dir) perl(Net::SSH2::File) perl(Net::SSH2::Listener) perl(Net::SSH2::PublicKey) perl(Net::SSH2::SFTP) perl-Net-SSH2 = 0.18-1.fc9 = libssh2.so.1()(64bit) perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(Exporter) perl(File::Basename) perl(IO::File) perl(Net::SSH2::Channel) perl(Net::SSH2::File) perl(Net::SSH2::Listener) perl(Net::SSH2::SFTP) perl(Socket) perl(XSLoader) perl(strict) perl(warnings) * %check is present and all tests pass: 61/72 skipped: - non-interactive session All tests successful, 61 subtests skipped. Files=1, Tests=72, 0 wallclock secs ( 0.04 cusr + 0.02 csys = 0.06 CPU) (Skipped tests are not runnable within mock) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED New Package CVS Request ======================= Package Name: perl-Net-SSH2 Short Description: Support for the SSH 2 protocol via libSSH2 Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig Imported and building. Thanks for the review! :) Package Change Request ====================== Package Name: perl-Net-SSH2 New Branches: Owners: InitialCC: perl-sig Please add perl-sig user with watch* permissions only to all Fedora branches. Done. Package Change Request ====================== Package Name: perl-Net-SSH2 New Branches: el6 Owners: psabata InitialCC: perl-sig Git done (by process-git-requests). |