Bug 2412927
| Summary: | Review Request: rust-reqsign-aliyun-oss - Aliyun OSS signing implementation for reqsign | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Terje Rosten <terjeros> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, terjeros |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | terjeros:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/reqsign-aliyun-oss | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-11-11 17:56:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ben Beasley
2025-11-05 20:19:11 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9770996 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2412927-rust-reqsign-aliyun-oss/fedora-rawhide-x86_64/09770996-rust-reqsign-aliyun-oss/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. (In reply to Fedora Review Service from comment #1) > Please make sure the package builds successfully at least for Fedora Rawhide. This needs "fedora-review --mock-options=--enablerepo=local …" until https://bodhi.fedoraproject.org/updates/FEDORA-2025-482bdfd1c5 appears in a Rawhide compose (probably within a day or so). [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/9775895 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2412927-rust-reqsign-aliyun-oss/fedora-rawhide-x86_64/09775895-rust-reqsign-aliyun-oss/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: rust-reqsign-aliyun-oss-devel-2.0.1-1.fc44.noarch.rpm
rust-reqsign-aliyun-oss+default-devel-2.0.1-1.fc44.noarch.rpm
rust-reqsign-aliyun-oss-2.0.1-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpejgcj1x_')]
checks: 32, packages: 3
3 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.1 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2
2 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.0 s
Source checksums
----------------
https://crates.io/api/v1/crates/reqsign-aliyun-oss/2.0.1/download#/reqsign-aliyun-oss-2.0.1.crate :
CHECKSUM(SHA256) this package : 1136faae3624d59a9f647dce9c9f9c86682957e2886db27b68891ad24465cdfb
CHECKSUM(SHA256) upstream package : 1136faae3624d59a9f647dce9c9f9c86682957e2886db27b68891ad24465cdfb
Requires
--------
rust-reqsign-aliyun-oss-devel (rpmlib, GLIBC filtered):
(crate(anyhow/default) >= 1.0.0 with crate(anyhow/default) < 2.0.0~)
(crate(async-trait/default) >= 0.1.0 with crate(async-trait/default) < 0.2.0~)
(crate(http/default) >= 1.0.0 with crate(http/default) < 2.0.0~)
(crate(log/default) >= 0.4.0 with crate(log/default) < 0.5.0~)
(crate(percent-encoding/default) >= 2.0.0 with crate(percent-encoding/default) < 3.0.0~)
(crate(reqsign-core/default) >= 2.0.1 with crate(reqsign-core/default) < 3.0.0~)
(crate(reqwest) >= 0.12.0 with crate(reqwest) < 0.13.0~)
(crate(reqwest/json) >= 0.12.0 with crate(reqwest/json) < 0.13.0~)
(crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~)
(crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~)
(crate(serde_json/default) >= 1.0.0 with crate(serde_json/default) < 2.0.0~)
cargo
rust
rust-reqsign-aliyun-oss+default-devel (rpmlib, GLIBC filtered):
cargo
crate(reqsign-aliyun-oss)
Provides
--------
rust-reqsign-aliyun-oss-devel:
crate(reqsign-aliyun-oss)
rust-reqsign-aliyun-oss-devel
rust-reqsign-aliyun-oss+default-devel:
crate(reqsign-aliyun-oss/default)
rust-reqsign-aliyun-oss+default-devel
All good,
package is APPROVED.
Thank you for the review! https://release-monitoring.org/project/386719/ The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-reqsign-aliyun-oss FEDORA-2025-71508c857c (rust-reqsign-aliyun-oss-2.0.1-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-71508c857c FEDORA-2025-71508c857c (rust-reqsign-aliyun-oss-2.0.1-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |