Bug 2413002

Please, use new packaging guideline:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/

$ go2rpm --name spoofdpi --profile vendor github.com/xvzc/SpoofDPI

Spec URL: https://dump.neelc.org/fedora/packages/spoofdpi/spoofdpi.spec
SRPM URL: https://dump.neelc.org/fedora/packages/spoofdpi/spoofdpi-0.12.2-1.fc44.src.rpm
Source0:  https://dump.neelc.org/fedora/packages/spoofdpi/0/SpoofDPI-1.0.1.tar.gz
Source1:  https://dump.neelc.org/fedora/packages/spoofdpi/0/SpoofDPI-1.0.1-vendor.tar.bz2

I updated it. Is it good or are modifications needed?

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9775479
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2413002-spoofdpi/fedora-rawhide-x86_64/09775479-spoofdpi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: spoofdpi-0.12.2-1.fc44.x86_64.rpm
          golang-github-xvzc-spoofdpi-devel-0.12.2-1.fc44.noarch.rpm
          spoofdpi-0.12.2-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp2b20wvbz')]
checks: 32, packages: 3

spoofdpi.x86_64: W: no-manual-page-for-binary spoofdpi
golang-github-xvzc-spoofdpi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/xvzc/SpoofDPI/.goipath
 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 10 filtered, 0 badness; has taken 0.4 s 

Rpmlint (debuginfo)
-------------------
Checking: spoofdpi-debuginfo-0.12.2-1.fc44.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpwmxb_5jk')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.3 s 

Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

spoofdpi.x86_64: W: unused-direct-shlib-dependency /usr/bin/spoofdpi /lib64/libresolv.so.2
spoofdpi.x86_64: W: no-manual-page-for-binary spoofdpi
golang-github-xvzc-spoofdpi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/xvzc/SpoofDPI/.goipath
 3 packages and 0 specfiles checked; 0 errors, 3 warnings, 12 filtered, 0 badness; has taken 0.1 s 


Source checksums
----------------
https://github.com/xvzc/SpoofDPI/archive/v0.12.2/SpoofDPI-0.12.2.tar.gz :
  CHECKSUM(SHA256) this package     : 6b963e5c52e129f1bcac3b5adc59322715f5d31e593eb317e363c18c77f53a5b
  CHECKSUM(SHA256) upstream package : 6b963e5c52e129f1bcac3b5adc59322715f5d31e593eb317e363c18c77f53a5b


Requires
--------
spoofdpi (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libresolv.so.2()(64bit)
    rtld(GNU_HASH)

golang-github-xvzc-spoofdpi-devel (rpmlib, GLIBC filtered):
    go-filesystem
    golang(github.com/miekg/dns)
    golang(github.com/rs/zerolog)


Provides
--------
spoofdpi:
    spoofdpi
    spoofdpi(x86-64)

golang-github-xvzc-spoofdpi-devel:
    golang(github.com/xvzc/SpoofDPI/internal/appctx)
    golang(github.com/xvzc/SpoofDPI/internal/applog)
    golang(github.com/xvzc/SpoofDPI/internal/config)
    golang(github.com/xvzc/SpoofDPI/internal/datastruct)
    golang(github.com/xvzc/SpoofDPI/internal/dns)
    golang(github.com/xvzc/SpoofDPI/internal/dns/addrselect)
    golang(github.com/xvzc/SpoofDPI/internal/proxy)
    golang(github.com/xvzc/SpoofDPI/internal/system)
    golang(github.com/xvzc/SpoofDPI/version)
    golang-github-xvzc-spoofdpi-devel
    golang-ipath(github.com/xvzc/SpoofDPI)

Summary:
--------
 - update to latest version 1.0.1:
    https://github.com/xvzc/SpoofDPI/releases

> I updated it. Is it good or are modifications needed?

It seems you linked the wrong spec.

- old https://dump.neelc.org/fedora/packages/spoofdpi/spoofdpi.spec
- new https://dump.neelc.org/fedora/packages/spoofdpi/0/spoofdpi.spec

For the new spec:

> BuildRequires:  go-vendor-tools libpcap-devel

Use a BuildRequire per dependency

> Summary:        A simple and fast anti-censorship tool written in Go

You can remove the "A " from the beginning of the Summary.

> Use a BuildRequire per dependency
...
> You can remove the "A " from the beginning of the Summary.


Spec URL: https://dump.neelc.org/fedora/packages/spoofdpi/1/spoofdpi.spec
SRPM URL: https://dump.neelc.org/fedora/packages/spoofdpi/1/spoofdpi-0.12.2-1.fc44.src.rpm
Source0:  https://dump.neelc.org/fedora/packages/spoofdpi/1/SpoofDPI-1.0.1.tar.gz
Source1:  https://dump.neelc.org/fedora/packages/spoofdpi/1/SpoofDPI-1.0.1-vendor.tar.bz2

I updated it. Is it good or are modifications needed?

There seems to be some problem with the following file.
SRPM URL: https://dump.neelc.org/fedora/packages/spoofdpi/1/spoofdpi-0.12.2-1.fc44.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Updated URL list should be:

Spec URL: https://dump.neelc.org/fedora/packages/spoofdpi/1/spoofdpi.spec
SRPM URL: https://dump.neelc.org/fedora/packages/spoofdpi/1/spoofdpi-1.0.1-1.fc44.src.rpm
Source0:  https://dump.neelc.org/fedora/packages/spoofdpi/1/SpoofDPI-1.0.1.tar.gz
Source1:  https://dump.neelc.org/fedora/packages/spoofdpi/1/SpoofDPI-1.0.1-vendor.tar.bz2

Created attachment 2113283 [details]
The .spec file difference from Copr build 9775479 to 9777586

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9777586
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2413002-spoofdpi/fedora-rawhide-x86_64/09777586-spoofdpi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> Requires:       libpcap

You don't need this:


rpmbuilds adds to required dep itself:

$ rpm -qp --requires /export/RPMS/x86_64/spoofdpi-1.0.1-1.fc43.x86_64.rpm | grep pcap.so
libpcap.so.1()(64bit)

Fix that during import,

 package is APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/spoofdpi

FEDORA-2025-830ca25d8b (spoofdpi-1.0.1-2.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-830ca25d8b

FEDORA-2025-830ca25d8b (spoofdpi-1.0.1-2.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

If you have time, there are some packages pending for review e.g. :

 https://bugzilla.redhat.com/show_bug.cgi?id=2403381
 https://bugzilla.redhat.com/show_bug.cgi?id=2413078