Bug 241304 (perl-DBI-Dumper)
| Summary: | Review Request: perl-DBI-Dumper - Dump data from a DBI datasource to file | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ruben, wtogami |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/DBI-Dumper/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-31 01:25:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Weyl
2007-05-24 22:20:00 UTC
Hi Chris, This is my first review of a perl package, so I'd prefer if someone more experienced would have a look as well. But anyway, here we go: * RPM name is OK * Source DBI-Dumper-2.01.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK Notes: - What is grammar.prd, and does it need to be in the docs? grammar.prd is the grammar Parse::RecDescent definition used by DBI::Dumper. I figured it might be useful to someone wanting to take a deeper look at things... where can I find license text? any updates? (In reply to comment #5) > any updates? To what exactly? :) license inclusion in upstream tarball. Ping? The rt bug comments from the author tell us what the license is, namely, under the same terms as perl itself. He has also committed to including a statement to that effect in the next release of the distribution. I've updated the rpm to include a "COPYING.fedora" with the information from and a link to the licensing bug on rt.cpan.org. http://fedora.biggerontheinside.net/review/perl-DBI-Dumper-2.01-2.fc7.src.rpm http://fedora.biggerontheinside.net/review/perl-DBI-Dumper.spec Actually I was waiting for new upstream release but anyway as you have already added upstream clarification regarding license its ok now. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 402bc1aacf4b39f318fa5b2bf47d123d DBI-Dumper-2.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_use.......ok t/basic........ok t/dbidumper....Opening file: /tmp/QBa9Ygtduu 12 row(s) dumped. ok t/grammar......ok All tests successful. Files=4, Tests=131, 1 wallclock secs ( 1.10 cusr + 0.09 csys = 1.19 CPU) + Package perl-DBI-Dumper-2.01-2.fc8 -> Provides: C.so perl(DBI::Dumper) = 2.01 perl(DBI::Dumper::C) = 1.00 perl(DBI::Dumper::Grammar) perl(DBI::Dumper::PurePerl) perl(Parse::RecDescent::DBI::Dumper::Grammar) Requires: /usr/bin/perl libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl(:MODULE_COMPAT_5.8.8) perl(DBI) perl(DBI::Dumper) perl(DBI::Dumper::Grammar) perl(DBI::Dumper::PurePerl) perl(Inline) perl(Parse::RecDescent) perl(Time::HiRes) perl(strict) perl(vars) perl(warnings) rtld(GNU_HASH) APPROVED. New Package CVS Request ======================= Package Name: perl-DBI-Dumper Short Description: Dump data from a DBI datasource to file Owners: cweyl Branches: FC-6, F-7, F-8, devel InitialCC: perl-sig InitialCC: perl-sig InitialCC: perl-sig Done except for this. Given that this template must be machine readable, what do you mean? Oops, that did actually work. :) Imported and built! Thanks for the review :) |