Bug 241310

Summary: kernel 2.6.21-1.3180 breaks suspend
Product: [Fedora] Fedora Reporter: James Bowes <jbowes>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED RAWHIDE QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bkearney, dgunchev, fabrice, imoq, jarmo.rosenqvist, jeffutter, martin.sourada, tglx, tim, triage, valent.turkovic
Target Milestone: ---   
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard: bzcl34nup
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-04-05 15:48:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
/var/log/messages from when I tested it none

Description James Bowes 2007-05-24 23:53:45 UTC
On a Lenovo X60 (1709G3U), with kvm and iwl3945 blacklisted, resuming from
suspend to ram works with kernel 3176, but fails on 3180 (the next available
build from koji).

This occurs both when fully booted into X, and with 'init=/bin/bash'

Comment 1 Martin Sourada 2007-05-26 09:54:43 UTC
Same here on Acer TM 2490. I did some testing just before few minutes and with
the same configuration and installed packages it sucessfuly resumes with 3149
kernel and fails with both 3189 and latest 3194 kernel.

More info: suspend works with all three, however when I try to resume with the
two newer my hard disk works for a while and then stops. Screen remains turned
off, as well as USB optical mouse.

Comment 2 Martin Sourada 2007-05-27 18:45:20 UTC
Created attachment 155525 [details]
/var/log/messages from when I tested it

Adding /var/log/messages striped to include only info from the time I tested
suspend functionality with 3149, 3189 and 3194 kernel. Hope it helps. Also, I
can confirm, that resume broke in 3180 kernel build.

Comment 3 James Bowes 2007-05-27 20:12:40 UTC
I just ran through building and testing some kernels. It was specifically
the change to the 2.6.21.2rc1 patchset that caused the breakage.

Comment 4 Valent Turkovic 2007-05-28 09:11:43 UTC
Please read my suspend/resume troubles I had with my laptop...

for summary read only comment #32

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240964#c32

Comment 5 Valent Turkovic 2007-05-28 10:33:24 UTC
I can try installing 3163 kernel on my existing fedora7 test 4 installation and
see what happens...

But I can't find 3163 kernel anywhere, just a bunch of dead links.
http://www.google.com/search?q=kernel-2.6.21-1.3163.fc7.i686.rpm&hl=en

Can you help me out? Where can I download older kernels for F7?

Comment 6 Martin Sourada 2007-05-28 16:15:25 UTC
(In reply to comment #5)
> I can try installing 3163 kernel on my existing fedora7 test 4 installation and
> see what happens...
> 
> But I can't find 3163 kernel anywhere, just a bunch of dead links.
> http://www.google.com/search?q=kernel-2.6.21-1.3163.fc7.i686.rpm&hl=en
> 
> Can you help me out? Where can I download older kernels for F7?

In koji: http://koji.fedoraproject.org/koji/packageinfo?packageID=8


Comment 7 Valent Turkovic 2007-05-28 21:19:38 UTC
I just finished installing, updating, testing, rebooting... and after 5 hours of
testing I can claim that the current F7 kernel 3194 has a major bug preventing
laptops to resume.

I installed Fedora Live CD 20070517 with kernel 3163 on my HP Compaq nx7300
laptop and suspend works great with quirks (I just sent patches for HAL
regarding this). After updating to latest updated version of all packages except
kernel suspend/resume still works great.

When I update kernel to 3194 suspend works great but resume freezes the laptop.
There. :)

If you need more proof please tell me.

Comment 8 James Bowes 2007-05-29 22:01:53 UTC
davej suspected it might be timer changes, and suggested trying 'nohz=off'. This
didn't help for me.

Comment 9 Doncho Gunchev 2007-06-01 17:35:08 UTC
I am in the same situation - stuck with 2.6.21-1.3176 on Acer Aspire 5610.
hw-uuid e121f58f-2418-479e-9683-defc088c2168. Will try nohz=off with
2.6.21-1.3209.fc7 and report back if it works...

Comment 10 Martin Sourada 2007-06-03 18:12:29 UTC
Ok, I did some testing with vanila kernels and git-bisect and knowing the
3176.fc7 is based off vanila 2.6.21.1 and works and 3180.fc7 is based of
2.6.21.2-rc2 and does not work I set v2.6.21.1 as good and v2.6.21.2 as bad.
What was my surprise that with none of the bisect steps the suspend/resume
worked. So I extracted 2.6.21, applied 2.6.21.1 patches (form 3176 srpm) and
intalled the kernel, and suspend/resume didn't work. I am at the end of my wits.
I can edit the srpm and do hand bisect there, but I tried to remove/add some
patches to be more or less between 3176 and 3180 however the kernel compiled but
rpm didn't builded. I tried it twice with the same result: <probably some
process ID> killed. And classical rpmbuild error. 

I don't know what more I can do to check, which patch actualy breaks it. It
seems that the rpmed kernel has either specific config or specific patches that
made suspend/resume work, but some of the patches (about 35 minus already used 6
- that's about thirty patches, that's not so big number) from 2.6.21.2-rc2
apparently broke it.

Oh, and... I did the kernel compiling by make mrpoper, make oldconfig (asked me
only once and I left default setting there), make, make modules_install, make
install (the two latter as root...). Did I something wrong? Any ideas? Any
suggestions?

Comment 11 Martin Sourada 2007-06-03 20:01:40 UTC
More info:

I just tried 3212.fc7 kernel from koji, and with the same result - resume after
suspend does not work. Screen turned off, USB mouse as well, HDD LED flashes and
that's all. So I am still stuck with 3176.fc7 kernel...

Comment 12 Doncho Gunchev 2007-06-03 20:35:04 UTC
HDD LED is constantly on for me and I tried
http://people.freedesktop.org/~hughsient/quirk/quirk-advanced.html
with 3194.fc7 and got:
  hash matches drivers/base/power/resume.c:28
  hash matches device PNP0C0A:00
my /sys/bus/acpi/devices/PNP0C0A:00 has driver -> /sys/bus/acpi/drivers/battery
btw: nohz=off does not help

Comment 13 Alejandro Gonzalez Hernandez - Imoq 2007-06-06 18:25:00 UTC
I will just add a "me too", my laptop is an HP Compaq nx9420 and suspend SEEMS
to work fine, but it doesn't wake up.

kernel 2.6.21-1.3194.fc7

Comment 14 James Bowes 2007-06-08 01:55:17 UTC
kernel 2.6.21-1.3213.fc8 in rawhide does not have this problem, but it is still
present in the matching f7 kernel (2.6.12-1.3219.fc7).

Probably a 2.6.21 vs 2.6.22 thing.

Comment 15 Doncho Gunchev 2007-06-08 09:25:27 UTC
Same here, 2.6.21-1.3213.fc8 resumes, 2.6.12-1.3219.fc7 not. With 
2.6.21-1.3213.fc8 however, postfix fails to start at boot, but after the 
system has finished loading it can (SeLinux=permissive)?!?

Comment 16 Valent Turkovic 2007-06-09 09:21:01 UTC
Same here, 2.6.21-1.3213.fc8 suspend and resumes ok
2.6.21-1.3209.fc7 does not

Comment 17 Jeff Utter 2007-06-11 01:19:02 UTC
Same here on a Gateway M255. witht he F7 kernel it woudl not resume at all. With
the F8 kernel, it works _once_. Suspend/Resume/Suspend/Resume again, won't
resume the 2nd time, it acts just like the F7 kernel, does anyone else have the
same problem with the F8 one, or is it just me?

Comment 18 Fabrice Bellet 2007-06-21 16:15:12 UTC
on a thinkpad T60p, with kernel 2.6.21-1.3228.fc7, suspend to ram failed to wake
up, until I disabled hpet. 

After applying selectively patches from the src.rpm, I came to the conclusion
that linux-2.6-clockevents-fix-resume-logic.patch caused problems. Only applying
patches 10-99, 200-299, and 2402, (and excluding 2403 aka
linux-2.6-clockevents-fix-resume-logic.patch) made the kernel resume from
suspend, without the need to disable hpet, but it failed to resume after a
second suspend. Between the first and the second suspend, the kernel also
complained about soft lockups (if needed, I can produce the stack trace). 

Disabling hpet at boot time allows me to resume from suspend several times with
kernel 2.6.21-1.3228.fc7, that's why I think that
linux-2.6-clockevents-fix-resume-logic.patch is only a part of the problem.

echo 1 > /proc/sys/kernel/acpi_video_flags was required to properly restore the
video on resume. I made my tests with init=/bin/bash. And my mkinitrd preloads
modules ata_piix ahci.

Comment 19 Valent Turkovic 2007-06-26 14:17:01 UTC
is anybody at fedora or redhat looking at this? can you make us some beta kernel
without bad patches so that it gets out laptops to suspend and resume ok?

Comment 20 Chuck Ebbert 2007-06-26 15:51:45 UTC
Richard Hughes has a webpage for diagnosing this:
http://people.freedesktop.org/~hughsient/quirk/

Comment 21 Valent Turkovic 2007-06-26 17:31:15 UTC
Chuck please read my replies on this bug and my other bugs that I link to before
posting generic reply. I actively work with Hugh and on his Quirks page and this
is not enough to fix this bug. We need fedora/red hat developers to iron this
bugs out or make some test kernels for us to test using info in comment #18.

Comment 22 Chuck Ebbert 2007-06-26 18:13:25 UTC
I'm not sure what the status of the clockevents patch is. It's not upstream.
Thomas, can you look at this?


Comment 23 Martin Sourada 2007-07-16 00:33:07 UTC
I tested the suspend on the newest kernels - one stable and one rawhide. On
identical system configuration (fully updated F7). Note that the rawhide kernel
has a problem with loading modules, but boots...

RESULTS:

kernel-2.6.21-1.3228.fc7:
suspend: ok
resume: screen black, optical usb mouse not turned on, hdd LED on for about a
half a minute than it turns off, HDD however show no activity (i.e. no sound of
it could be heard). CTRL+ALT+F1 does nothing, even if I try to log in and type
find / nothing happens (screen remains black, HDD LED turned off, apparently no
action). Computer most likely frozen.

kernel-2.6.23-0.15.rc0.git1.fc8:
suspend: ok
resume: ok


Comment 24 Doncho Gunchev 2007-07-17 21:07:45 UTC
kernel-2.6.23-0.29.rc0.git6.fc8.i686 works fine for me (suspend to RAM/disk) 
with FC7, while 2.6.22.1-20.fc7 locks the system at resume after suspend (to 
RAM).
Martin, thank you for the fc8 kernel on fc7 tip :-)

Comment 25 Valent Turkovic 2007-07-18 17:45:57 UTC
I'm running 

# uname -r
2.6.22-8.fc7

and my laptop suspends but locks on resume.

Comment 26 Doncho Gunchev 2007-07-19 12:06:37 UTC
(In reply to comment #25)
> # uname -r
> 2.6.22-8.fc7
> 
> and my laptop suspends but locks on resume.

please try kernel-2.6.23-0.29.rc0.git6.fc8.i686 or 
kernel-2.6.23-0.30.rc0.git6.fc8.i686, they both work fine for me (ex: 
http://koji.fedoraproject.org/koji/buildinfo?buildID=11395)

I'll try to run every 2.6.23-xx kernel and find the version in which it starts 
to work for me... if time permits...

Comment 27 Valent Turkovic 2007-07-19 18:07:26 UTC
# uname -a
Linux fedora7 2.6.23-0.29.rc0.git6.fc8 #1 SMP Mon Jul 16 17:14:27 EDT 2007 i686
i686 i386 GNU/Linux

# lshal |grep quirk
  power_management.quirk.vbe_post = true  (bool)
  power_management.quirk.vbemode_restore = true  (bool)


suspend: ok

resume: screen black, HDD however show no activity (i.e. no sound of
it could be heard). CTRL+ALT+F1 does nothing, even if I try to log in and type
find / nothing happens (screen remains black, HDD LED turned off, apparently no
action). Computer most likely frozen.

I have HP Compaq nx7300 laptop

Comment 28 Doncho Gunchev 2007-07-25 18:03:20 UTC
Just for the record, with kernel-2.6.23-0.29.rc0.git6.fc8.i686 my laptop 
suspends to RAM and resumes fine. With the next possible (git14 I think) 
kernel it does not work again... :-(   (Acer Aspire 5610)

Comment 29 Doncho Gunchev 2007-08-05 20:23:47 UTC
I compiled 2.6.23-rc2 with configuration based on fedora's kernels but turned 
off the new PATA/IDE subsystem (now I have /dev/hda instead of /dev/sda and 
IPv6 disabled) and suspend to ram works again. My previous attempt (2.6.23-rc1 
I think) with the new PATA/IDE subsystem failed.
I will recompile and try rc2 with the new subsystem if that would help...

Comment 30 Doncho Gunchev 2007-11-12 02:24:44 UTC
For the record, kernel parameter hpet=disable fixed thing for me with fc7, fc8 
seems to not need this any more :-)

Comment 31 Bug Zapper 2008-04-04 00:54:49 UTC
Based on the date this bug was created, it appears to have been reported
against rawhide during the development of a Fedora release that is no
longer maintained. In order to refocus our efforts as a project we are
flagging all of the open bugs for releases which are no longer
maintained. If this bug remains in NEEDINFO thirty (30) days from now,
we will automatically close it.

If you can reproduce this bug in a maintained Fedora version (7, 8, or
rawhide), please change this bug to the respective version and change
the status to ASSIGNED. (If you're unable to change the bug's version
or status, add a comment to the bug and someone will change it for you.)

Thanks for your help, and we apologize again that we haven't handled
these issues to this point.

The process we're following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

Comment 32 Jon Stanley 2008-04-05 15:48:58 UTC
closing based on comment #30