Bug 241387

First look:

- packaging guidelines strongly encourage a full source url

- shouldn't the python stuff go in /usr/lib/python2.5 ?

- either way, as long as it lives in libdir, the package cannot be noarch


There are also some missing dependencies, apparently:

[mclasen@dhcp83-186 devel]$ codeina 
GTK Accessibility Module initialized
Traceback (most recent call last):
  File "/usr/bin/codeina", line 101, in <module>
    _run_codeina()
  File "/usr/bin/codeina", line 89, in _run_codeina
    from codeina import main
  File "/usr/lib/codeina/python/codeina/main.py", line 36, in <module>
    from codeina import configure, check, install, myutils, productlist
  File "/usr/lib/codeina/python/codeina/install.py", line 32, in <module>
    import myutils
  File "/usr/lib/codeina/python/codeina/myutils.py", line 29, in <module>
    from xdg import BaseDirectory
ImportError: No module named xdg

(In reply to comment #1)
> First look:
> 
> - packaging guidelines strongly encourage a full source url

No releases done yet, so no URL.

> - shouldn't the python stuff go in /usr/lib/python2.5 ?

I'd rather it went in /usr/share altogether actually.

> - either way, as long as it lives in libdir, the package cannot be noarch

So I should move the python code to /usr/share (there's no compiled bits).

> There are also some missing dependencies, apparently:
> 
> [mclasen@dhcp83-186 devel]$ codeina 
<snip>
> ImportError: No module named xdg

Yeah, it's missing pyxdg.

I've mentioned that the code should be moved to the python directories, or
$(datadir) upstream.

Ok, I'll run down the review checklist once there is a srpm with these issues
fixed (well, the source url thing was already explained away)

See http://fedoraproject.org/wiki/PackagingDrafts/Python for the official gospel
of where to put python and how to put that in the spec.

Any update on this, Bastien ?

Nothing yet, waiting on the Codeina guys to update their code (Edward is
supposed to work on it soon).

Updated package and spec:
http://people.redhat.com/bnocera/codeina/codeina-0.10.0.1-0.20070525.170400.2.src.rpm
http://people.redhat.com/bnocera/codeina/codeina.spec

It took me a while to work around codeina's broken dir names, but I managed it
in the end. The source SVN wasn't updated as there were no changes since the
last SVN snapshot.

Removing the fedora_cvs flag, I turned it on accidentally.

With the absence of a full URL to source, could you at least include anonymous
checkout instructions in a comment above it?

(In reply to comment #10)
> With the absence of a full URL to source, could you at least include anonymous
> checkout instructions in a comment above it?

Sure, I'll add the details we have from the CodecBuddy wiki page.

maybe add a %{?dist} tag?

what's the 
BuildRequires:  gcc-c++
followed by:
BuildArch:      noarch

about?

You use $RPM_BUILD_ROOT in some places and %{buildroot} in others, which is a
little inconsistent

mock build fails with 

Possible unintended interpolation of @INTLTOOL_ICONV in string at
../intltool-merge line 96
Global symbol "@INTLTOOL_ICONV" requires explicit package name at
../intltool-merge line 96.

not sure what that's about

(In reply to comment #12)
> maybe add a %{?dist} tag?
> 
> what's the 
> BuildRequires:  gcc-c++
> followed by:
> BuildArch:      noarch
> 
> about?

You didn't see the "sigh, libtool" comment. Basically, libtool needed it, and
complained if it's not there. Not the case anymore though, thus removed.

> You use $RPM_BUILD_ROOT in some places and %{buildroot} in others, which is a
> little inconsistent

Fixed.

> mock build fails with 
> 
> Possible unintended interpolation of @INTLTOOL_ICONV in string at
> ../intltool-merge line 96
> Global symbol "@INTLTOOL_ICONV" requires explicit package name at
> ../intltool-merge line 96.
> 
> not sure what that's about

Version mismatch between the tarball intltool and the system one. Running
intltoolize fixes it.

Build properly under mock.

http://people.redhat.com/bnocera/codeina/codeina-0.10.0.1-0.20070525.170400.3.fc8.src.rpm
http://people.redhat.com/bnocera/codeina/codeina.spec

Only thing that bothers me a little is

install -D -m 0755 %{SOURCE1}
$RPM_BUILD_ROOT%{_libexecdir}/gst-install-plugins-helper.sh

should that go into %{_libexecdir}/codeina/gst-install-plugins-helper.sh

?  Regardless of the answer to that question looks good.

(In reply to comment #14)
> Only thing that bothers me a little is
> 
> install -D -m 0755 %{SOURCE1}
> $RPM_BUILD_ROOT%{_libexecdir}/gst-install-plugins-helper.sh
> 
> should that go into %{_libexecdir}/codeina/gst-install-plugins-helper.sh

No, gst-install-plugins-helper is the hook for gstreamer uses to call the plugin
helper, so this needs to match the path used in GStreamer.

> ?  Regardless of the answer to that question looks good.

The question, or the package? :)

New Package CVS Request
=======================
Package Name: codeina
Short Description: GStreamer Codec Installation Application
Owners: hadess thomasvs
Branches: devel
InitialCC: bnocera thomas
Commits by cvsextras: yes

It was missing a gawk BR (is it not in the minimum builds anymore?), pushed to
rawhide.