Bug 2414339
| Summary: | Review Request: zsv - Tabular data Swiss-army knife CLI | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Azeem Sajid <azeem.sajid> | ||||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | benson_muite, code, package-review, terjeros | ||||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | https://github.com/liquidaty/zsv | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | --- | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | Type: | --- | |||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Azeem Sajid
2025-11-12 07:59:28 UTC
Created attachment 2114042 [details]
RPM spec file
Created attachment 2114044 [details]
SRPM
Can you please post direct links to spec file and srpm? (In reply to Terje Rosten from comment #3) > Can you please post direct links to spec file and srpm? Please find the direct links below: - spec: https://raw.githubusercontent.com/liquidaty/zsv/ffe51eeddc22f8143cab4c23914b97d63c8f40cc/pkg/rpm/rpmbuild/SPECS/zsv.spec - srpm: https://github.com/liquidaty/zsv/raw/ffe51eeddc22f8143cab4c23914b97d63c8f40cc/pkg/rpm/rpmbuild/SRPMS/zsv-1.1.0-1.fc44.src.rpm Added in the description as well. Thanks! Fedora packages need to be built from source. Guildelines for C: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ If you are not a packager, you may also want to examine: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/ The ticket summary is not in the correct format.
Expected:
Review Request: <main package name here> - <short summary here>
Found:
zsv+lib: tabular data swiss-army knife CLI + world's fastest (simd) CSV parser
As a consequence, the package name cannot be parsed and submitted to
be automatically build. Please modify the ticket summary and trigger a
build by typing [fedora-review-service-build].
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/9793200 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2414339-zsv/fedora-rawhide-x86_64/09793200-zsv/fedora-review/review.txt Found issues: - Package has .a files: zsv-devel. Does not provide -static: zsv-devel. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/9793478 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2414339-zsv/fedora-rawhide-x86_64/09793478-zsv/fedora-review/review.txt Found issues: - Package has .a files: zsv-devel. Does not provide -static: zsv-devel. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - Spec URL: https://raw.githubusercontent.com/liquidaty/zsv/8f082fc96f3803a1f0d8f05a8fd98575d0a36636/pkg/rpm/rpmbuild/SPECS/zsv.spec - SRPM URL: https://github.com/liquidaty/zsv/raw/8f082fc96f3803a1f0d8f05a8fd98575d0a36636/pkg/rpm/rpmbuild/SRPMS/zsv-1.1.0-1.fc44.src.rpm Created attachment 2114240 [details]
The .spec file difference from Copr build 9793478 to 9793481
Copr build: https://copr.fedorainfracloud.org/coprs/build/9793481 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2414339-zsv/fedora-rawhide-x86_64/09793481-zsv/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. We try to avoid packaging static libraries as much as possible, https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries. From https://github.com/liquidaty/zsv/blob/d3c63d15abf7e4d881eff088c480e3fe6482a45e/configure#L42, it looks like you should be able to build a shared library by passing --enable-shared to the configure script. I haven’t checked if the resulting shared library would be properly versioned; if not, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning. (In reply to Ben Beasley from comment #14) > We try to avoid packaging static libraries as much as possible, > https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static- > libraries. > > From > https://github.com/liquidaty/zsv/blob/ > d3c63d15abf7e4d881eff088c480e3fe6482a45e/configure#L42, it looks like you > should be able to build a shared library by passing --enable-shared to the > configure script. I haven’t checked if the resulting shared library would be > properly versioned; if not, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_downstream_so_name_versioning. I'm working with the upstream to generate the versioned dynamic library instead. I'll update and resubmit the new spec and SRPM once that becomes available. |