Bug 2415009

Summary: Review Request: rust-astral-tl - Fast HTML parser written in pure Rust
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Cristian Le <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-11-14 21:43:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2414686    
Attachments:
Description Flags
Configuration file for rust2rpm none

Description Ben Beasley 2025-11-14 11:07:33 UTC
Spec URL: https://music.fedorapeople.org/rust-astral-tl.spec
SRPM URL: https://music.fedorapeople.org/rust-astral-tl-0.7.9-1.fc43.src.rpm
Description: Fast HTML parser written in pure Rust.
Fedora Account System Username: music

Astral has taken their fork of the tl crate and published it. This is great! Previously, this was a git dependency in uv, accomplished in Fedora by bundling an extra source tarball. This package is a near-duplicate of https://src.fedoraproject.org/rpms/rust-tl, which I will orphan.

Comment 1 Ben Beasley 2025-11-14 11:10:22 UTC
Created attachment 2114372 [details]
Configuration file for rust2rpm

Comment 2 Cristian Le 2025-11-14 12:02:10 UTC
LGTM, it's even only 7 commits away from the fork so straightforward to review the changes also.

About orphaning `rust-tl`, is there some discussion on if maybe it would be revived, just 1 year inactivity, not sure if it would come-back after it. But at the very least, maybe post on https://github.com/y21/tl/issues/76 about alternatives to move to?

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Ben Beasley 2025-11-14 12:26:08 UTC
Thank you for the review!

(In reply to Cristian Le from comment #2)
> LGTM, it's even only 7 commits away from the fork so straightforward to
> review the changes also.
> 
> About orphaning `rust-tl`, is there some discussion on if maybe it would be
> revived, just 1 year inactivity, not sure if it would come-back after it.
> But at the very least, maybe post on https://github.com/y21/tl/issues/76
> about alternatives to move to?

Well, rust-tl has been a leaf package in Fedora for a long time. I continued maintaining it because I hoped that there might be some activity on the key PR https://github.com/y21/tl/pull/69, perhaps eventually allowing uv to go back to using the crates.io package, and because rust-tl was a useful bellwether for any issues with the fork bundled in the uv package.

Now it’s been nearly two years since any kind of upstream activity, and the key PR https://github.com/y21/tl/pull/69 is over a year old. I don’t think it’s coming back, and I don’t see any reason to keep maintaining it as a leaf package indefinitely.

I did comment in https://github.com/y21/tl/issues/76#issuecomment-3532496508 to mention this fork as an alternative for frustrated tl users, though.

Comment 4 Fedora Admin user for bugzilla script actions 2025-11-14 21:22:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-astral-tl

Comment 5 Ben Beasley 2025-11-14 21:24:11 UTC
https://release-monitoring.org/project/386806/

Comment 6 Fedora Update System 2025-11-14 21:40:42 UTC
FEDORA-2025-b94edb099c (rust-astral-tl-0.7.9-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b94edb099c

Comment 7 Fedora Update System 2025-11-14 21:43:27 UTC
FEDORA-2025-b94edb099c (rust-astral-tl-0.7.9-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.