Bug 2415754

There seems to be some problem with the following file.
SRPM URL: https://fedorapeople.org/~limb/review/python-call-graph/python-call-graph-2.1.6-1.fc44.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9819081
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2415754-python-call-graph/fedora-rawhide-x86_64/09819081-python-call-graph/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Rpmlint
-------
Checking: python3-python-call-graph-2.1.6-1.fc44.noarch.rpm
          python3-python-call-graph+ipython-2.1.6-1.fc44.noarch.rpm
          python3-python-call-graph+memory-psutil-2.1.6-1.fc44.noarch.rpm
          python-call-graph-2.1.6-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpv5k41oci')]
checks: 32, packages: 4

python-call-graph.src: E: spelling-error ('Visualises', "Summary(en_US) Visualises -> Visualizes, Visualizers, Visualizer's")
python3-python-call-graph.noarch: E: spelling-error ('Visualises', "Summary(en_US) Visualises -> Visualizes, Visualizers, Visualizer's")
python3-python-call-graph.noarch: W: no-manual-page-for-binary pycallgraph
python3-python-call-graph.noarch: W: no-documentation
python3-python-call-graph.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/python_call_graph-2.1.6.dist-info/METADATA
python3-python-call-graph.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/python_call_graph-2.1.6.dist-info/licenses/LICENSE
 4 packages and 0 specfiles checked; 4 errors, 2 warnings, 25 filtered, 4 badness; has taken 0.4 s 


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

python3-python-call-graph.noarch: E: spelling-error ('Visualises', 'Summary(en_US) Visualises -> Visualizes, Visualize, Visuals')
python3-python-call-graph.noarch: W: no-manual-page-for-binary pycallgraph
python3-python-call-graph.noarch: W: no-documentation
python3-python-call-graph.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/python_call_graph-2.1.6.dist-info/METADATA
python3-python-call-graph.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/python_call_graph-2.1.6.dist-info/licenses/LICENSE
 3 packages and 0 specfiles checked; 3 errors, 2 warnings, 21 filtered, 3 badness; has taken 0.2 s 


Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/python-call-graph/python-call-graph-2.1.6.tar.gz :
  CHECKSUM(SHA256) this package     : 24d49b1f348b6d85ab5ee886b240d38b983574e995bf38c18bbbe4c01865d950
  CHECKSUM(SHA256) upstream package : 24d49b1f348b6d85ab5ee886b240d38b983574e995bf38c18bbbe4c01865d950

Requires
--------
python3-python-call-graph (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)

python3-python-call-graph+ipython (rpmlib, GLIBC filtered):
    python(abi)
    python3-python-call-graph
    python3.14dist(ipython)
    python3.14dist(packaging)

python3-python-call-graph+memory-psutil (rpmlib, GLIBC filtered):
    python(abi)
    python3-python-call-graph
    python3.14dist(psutil)

Provides
--------
python3-python-call-graph:
    python-python-call-graph
    python3-python-call-graph
    python3.14-python-call-graph
    python3.14dist(python-call-graph)
    python3dist(python-call-graph)

python3-python-call-graph+ipython:
    python-python-call-graph+ipython
    python3-python-call-graph+ipython
    python3.14-python-call-graph+ipython
    python3.14dist(python-call-graph[ipython])
    python3dist(python-call-graph[ipython])

python3-python-call-graph+memory-psutil:
    python-python-call-graph+memory-psutil
    python3-python-call-graph+memory-psutil
    python3.14-python-call-graph+memory-psutil
    python3.14dist(python-call-graph[memory-psutil])
    python3dist(python-call-graph[memory-psutil])


 Summary:
---------
 - change URL to https://github.com/lewiscowles1986/py-call-graph/
 - check if you can get pytest to run in %check
 - there is manual page available as man/pycallgraph.1
   skip it?

Updated URL. Tests cannot currently be run due to non-packaged and possibly dead module.  Added man page.

Same URLs.

Ok, I see. What module is that? Upstream don't work run test?

Any way, it's not a blocker,

  package is APPROVED

Thank you!

I module is 'calls', and it has some fairly old dependencies.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-call-graph

FEDORA-2025-af5ef75de7 (python-call-graph-2.1.6-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-af5ef75de7

FEDORA-2025-af5ef75de7 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-af5ef75de7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-af5ef75de7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-af5ef75de7 (python-call-graph-2.1.6-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.