Bug 241608
Summary: | typo/bug in /usr/sbin/bind-chroot-admin | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | D. Hugh Redelmeier <hugh> |
Component: | bind | Assignee: | Adam Tkac <atkac> |
Status: | CLOSED DUPLICATE | QA Contact: | Ben Levenson <benl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 6 | CC: | ovasik |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-05-29 11:33:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
D. Hugh Redelmeier
2007-05-28 21:09:06 UTC
Oops -- [ is a version of test(1) not expr(1). So that the fixed line should be if expr "$ENABLE_ZONE_WRITE" : '[yY1]*' ; then A more traditional replacement would be a case statement replacing the whole if: case "$ENABLE_ZONE_WRITE" in [yY1]*) return 0 ;; esac The test(1) operator = is correct and == is a BASHism. For maximum portability, line 215 should use = instead of ==. At some point the script might be run by ash/dash/busybox (perhaps for performance reasons). The dash manual that I have does not document ==. (The expr command isn't listed as a dash builtin so that is one reason to use the case formulation I mentioned above.) Sorry for problems, already fixed in 9.3.4-6.fc6 (http://people.redhat.com/atkac/bind/). I could change == to = in rawhide. But I don't think that this is absolutely necessary because chroot-admin is bash script. Regards, Adam *** This bug has been marked as a duplicate of 241103 *** |